Skip to content

chore(deps): update dependency url-parse to 1.5.9 [security] - abandoned#73

Open
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/npm-url-parse-vulnerability
Open

chore(deps): update dependency url-parse to 1.5.9 [security] - abandoned#73
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/npm-url-parse-vulnerability

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate Bot commented May 9, 2021

Mend Renovate

This PR contains the following updates:

Package Change
url-parse 1.4.7 -> 1.5.9

GitHub Vulnerability Alerts

CVE-2021-27515

url-parse before 1.5.0 mishandles certain uses of backslash such as http:/ and interprets the URI as a relative path.

CVE-2021-3664

Overview

Affected versions of npm url-parse are vulnerable to URL Redirection to Untrusted Site.

Impact

Depending on library usage and attacker intent, impacts may include allow/block list bypasses, SSRF attacks, open redirects, or other undesired behavior.

CVE-2022-0512

Authorization Bypass Through User-Controlled Key in NPM url-parse prior to 1.5.6.

CVE-2022-0686

url-parse prior to version 1.5.8 is vulnerable to Authorization Bypass Through User-Controlled Key.

CVE-2022-0639

A specially crafted URL with an '@​' sign but empty user info and no hostname, when parsed with url-parse, url-parse will return the incorrect href. In particular,

parse(\"http://@​/127.0.0.1\")

Will return:

{
 slashes: true,
 protocol: 'http:',
 hash: '',
 query: '',
 pathname: '/127.0.0.1',
 auth: '',
 host: '',
 port: '',
 hostname: '',
 password: '',
 username: '',
 origin: 'null',
 href: 'http:///127.0.0.1'
 }

If the 'hostname' or 'origin' attributes of the output from url-parse are used in security decisions and the final 'href' attribute of the output is then used to make a request, the decision may be incorrect.

CVE-2022-0691

Leading control characters in a URL are not stripped when passed into url-parse. This can cause input URLs to be mistakenly be interpreted as a relative URL without a hostname and protocol, while the WHATWG URL parser will trim control characters and treat it as an absolute URL.

If url-parse is used in security decisions involving the hostname / protocol, and the input URL is used in a client which uses the WHATWG URL parser, the decision may be incorrect.

This can also lead to a cross-site scripting (XSS) vulnerability if url-parse is used to check for the javascript: protocol in URLs. See following example:

const parse = require('url-parse')
const express = require('express')
const app = express()
const port = 3000

url = parse(\"\\bjavascript:alert(1)\")

console.log(url)

app.get('/', (req, res) => {
 if (url.protocol !== \"javascript:\") {res.send(\"<a href=\\'\" + url.href + \"\\'>CLICK ME!</a>\")}
 })

app.listen(port, () => {
 console.log(`Example app listening on port ${port}`)
 })

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2021

Codecov Report

Merging #73 (d1cfb55) into master (1305c38) will decrease coverage by 7.09%.
The diff coverage is n/a.

❗ Current head d1cfb55 differs from pull request most recent head 9329c5a. Consider uploading reports for the commit 9329c5a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   65.78%   58.69%   -7.10%     
==========================================
  Files           7        7              
  Lines          38       46       +8     
  Branches        3        4       +1     
==========================================
+ Hits           25       27       +2     
- Misses         12       18       +6     
  Partials        1        1              
Impacted Files Coverage Δ
App.js 63.15% <0.00%> (-8.28%) ⬇️
reducers/api.js 36.36% <0.00%> (-8.09%) ⬇️
reducers/login.js 50.00% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1305c38...9329c5a. Read the comment docs.

@renovate renovate Bot changed the title chore(deps): update dependency url-parse to 1.5.0 [security] chore(deps): update dependency url-parse to 1.5.2 [security] Oct 18, 2021
@renovate renovate Bot force-pushed the renovate/npm-url-parse-vulnerability branch from d1cfb55 to 9329c5a Compare March 7, 2022 16:54
@renovate renovate Bot changed the title chore(deps): update dependency url-parse to 1.5.2 [security] chore(deps): update dependency url-parse to 1.5.9 [security] Mar 7, 2022
@renovate renovate Bot changed the title chore(deps): update dependency url-parse to 1.5.9 [security] chore(deps): update dependency url-parse to 1.5.9 [security] - abandoned Mar 24, 2023
@renovate
Copy link
Copy Markdown
Author

renovate Bot commented Mar 24, 2023

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant