You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 24, 2024. It is now read-only.
This issue collects some quality issues we've identified when trying to debug a problem using the log files alone. Feel free to edit and add more items.
1. In BR, an error due to context.Canceled should not produce any log above DEBUG level. This is just visual clutter and mask the real error.
2. In BR, logs of errors from TiKV should include the IP address of the TiKV, so that we don't need to fetch the log from every node in the cluster.
3. In TiKV, the download step should record how long the process has taken (whether success or not).
4. In BR, retryable errors should not result in an [ERROR] level log.
6. In BR, ensure all keys are formatted using upper-case hex. We can wrap keys in kv.Key to get the proper format. Printing []byte using zap.Binary will get base64 output (wrong) while using zap.Reflect will get you even worse stuff like "t\\u0000\\u0000….Print keys on log as hex string #359
This issue collects some quality issues we've identified when trying to debug a problem using the log files alone. Feel free to edit and add more items.
context.Canceledshould not produce any log above DEBUG level. This is just visual clutter and mask the real error.downloadstep should record how long the process has taken (whether success or not).5. In BR restore, the "Full restore" is printed too frequently (0.2s/log?!), drowning out useful information.utils: fix excessive refresh frequency when BR_LOG_TO_TERM=1 #3346. In BR, ensure all keys are formatted using upper-case hex. We can wrap keys inPrint keys on log as hex string #359kv.Keyto get the proper format. Printing[]byteusingzap.Binarywill get base64 output (wrong) while usingzap.Reflectwill get you even worse stuff like"t\\u0000\\u0000….