Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

lightning: cherry-pick some PRs (#1458)#1459

Closed
ti-chi-bot wants to merge 1 commit into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-1458-to-release-5.0
Closed

lightning: cherry-pick some PRs (#1458)#1459
ti-chi-bot wants to merge 1 commit into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-1458-to-release-5.0

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #1458

What problem does this PR solve?

cherry-pick pingcap/tidb#27769 and pingcap/tidb#30393

also cherry-pick pingcap/tidb#29730 to pass integration test

also partically cherry-pick pingcap/tidb#29062 to fix some unstable integration tests

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Fix the bug that tidb-lightning can only read at most 1000 files from gcs storage.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Copy Markdown
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Copy Markdown
Collaborator

glorv commented Jan 25, 2022

Seems most of these features are not supported by release-5.0, closed then.

@glorv glorv closed this Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants