Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

cherry-pick #155#164

Closed
3pointer wants to merge 1 commit into
pingcap:release-3.1from
3pointer:release-3.1
Closed

cherry-pick #155#164
3pointer wants to merge 1 commit into
pingcap:release-3.1from
3pointer:release-3.1

Conversation

@3pointer
Copy link
Copy Markdown
Collaborator

cherry-pick Incremental BR: support DDL (#155) to release-3.1

* support backup&restore ddl

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* integration tests

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* update kvproto

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix integration tests

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* reduce cyclomatic complexity of `runRestore`

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* add unit test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix tests

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* disable fast checksum in incremental br

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix no valid key error

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address lint

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@3pointer 3pointer requested a review from 5kbpers February 21, 2020 04:03
@kennytm
Copy link
Copy Markdown
Collaborator

kennytm commented Feb 21, 2020

[2020-02-21T04:06:49.401Z] panic: runtime error: invalid memory address or nil pointer dereference

[2020-02-21T04:06:49.401Z] [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x22adf8f]

[2020-02-21T04:06:49.401Z] 

[2020-02-21T04:06:49.401Z] goroutine 189 [running]:

[2020-02-21T04:06:49.401Z] github.com/pingcap/br/pkg/restore.(*DB).ExecDDL(0xc000d74e80, 0x2c13e80, 0xc000e41f80, 0xc0014fcdd0, 0x276282fb00000000, 0xc000cb9628)

[2020-02-21T04:06:49.401Z] 	/home/jenkins/agent/workspace/br_ghpr_integration_test_3.1/go/src/github.com/pingcap/br/pkg/restore/db.go:46 +0x67f

@3pointer 3pointer closed this Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants