This repository was archived by the owner on Jul 24, 2024. It is now read-only.
*: move lightning code into br#512
Merged
Merged
Conversation
kennytm
reviewed
Sep 17, 2020
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package decoder |
Collaborator
There was a problem hiding this comment.
should this file be placed in pkg/decoder/decoder.go or perhaps better pkg/cdclog/decoder.go
Collaborator
Author
There was a problem hiding this comment.
I prefer put it in pkg/cdclog/decoder.go @overvenus #482 (comment) WDYT?
Collaborator
Author
|
/run-integration-test |
overvenus
reviewed
Sep 18, 2020
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package cdclog |
Member
There was a problem hiding this comment.
Could you move the package to pkg too?
ti-srebot
approved these changes
Sep 18, 2020
Collaborator
Author
|
/run-integration-test |
Contributor
|
cherry pick to release-4.0 in PR #529 |
overvenus
pushed a commit
that referenced
this pull request
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Split #482
What is changed and how it works?
move lightning code into br.
Check List
Tests
Related changes
Release Note