This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Update the errors/parser dependence to the latest version#593
Merged
Conversation
Signed-off-by: Lonng <heng@lonng.org>
|
|
lonng
requested review from
kennytm and
overvenus
and removed request for
kennytm
kennytm
reviewed
Nov 10, 2020
Collaborator
kennytm
left a comment
kennytm
left a comment
There was a problem hiding this comment.
LGTM.
Please sign the CLA.
Contributor
Author
|
oops, seems to compile failure after merging master. |
Collaborator
|
/rebuild |
Contributor
Author
|
@overvenus Can the release-4.0 branch use the master branch of the parser? |
Member
Not sure, we need to test. For now, BR keeps parser/kvproto the same as TiDB release-4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
The PR pingcap/tiup#867 introduces functions that will merge the workaround/description from errors.toml with the error message from the repository. Make sure there are no conflicts between code and error metafile, the PR pingcap/errors#31 remove workaround/description options.
What is changed and how it works?
Check List
Tests
Release Note