This repository was archived by the owner on Jul 24, 2024. It is now read-only.
pd: fix parse version#620
Merged
Merged
Conversation
Collaborator
Author
|
/run-integration-test |
Collaborator
Author
|
/run-integration-test |
Collaborator
Author
|
/run-integration-test |
Collaborator
|
LGTM |
ti-srebot
approved these changes
Nov 26, 2020
Contributor
|
/merge |
Contributor
|
/run-all-tests |
1 similar comment
Contributor
|
/run-all-tests |
Contributor
|
@3pointer merge failed. |
Contributor
|
/run-all-tests |
Contributor
|
/rebuild |
1 similar comment
Contributor
|
/rebuild |
Collaborator
|
/run-all-tests |
1 similar comment
Collaborator
Author
|
/run-all-tests |
Collaborator
Author
|
/run-integration-test |
Collaborator
Author
|
/run-integration-test |
Contributor
|
cherry pick to release-4.0 in PR #623 |
ti-srebot
added a commit
that referenced
this pull request
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
current parse pd version will failed. this bug is introduced in #592.
What is changed and how it works?
add strings.Trim before parse version
Check List
Tests
Related changes
Release Note