This repository was archived by the owner on Jul 24, 2024. It is now read-only.
lightning: Fix lints for lightning#766
Merged
Merged
Conversation
YuJuncen
changed the title
Co-authored-by: Neil Shen <overvenus@gmail.com>
Member
|
/lgtm |
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
Co-authored-by: glorv <glorvs@163.com>
Collaborator
Author
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 9baf6ea |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Apr 7, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #988 |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Apr 7, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-5.0 in PR #989 |
ti-chi-bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
CI for
tidb-lightningdoesn't include lints, after merged into this repository, we hope it can pass the CI tests too.What is changed and how it works?
Refactoring following what the linter says.
NOTEs
Those linters are disabled:
Standard
errorsuseserr.Unwrap()to get cause of errors. Butpingcap/errorsuseserr.Cause()anderrors.Unwrap(err). If we follow this linter, usingerrors.Isto check error class, causes of errors would be omitted.errors.Trace(err), which is tricky, and in someway not really wrapped those errors. Maybe we need farther refactoring for error returning.Check List
Tests
Code changes
Release Note