This repository was archived by the owner on Jul 24, 2024. It is now read-only.
*: unify version and set max compatible via NextMajorVersion#798
Merged
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
8 tasks
Signed-off-by: Neil Shen <overvenus@gmail.com>
glorv
reviewed
Mar 10, 2021
| return nil, errors.Trace(err) | ||
| } | ||
|
|
||
| return semver.NewVersion(rawVersion) |
Collaborator
There was a problem hiding this comment.
The raw version string fetch from pd is quoted, I think we need to trim the " here.
> curl http://172.16.4.5:2379/pd/api/v1/config/cluster-version
"4.0.8"
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Collaborator
|
/lgtm |
Collaborator
|
/lgtm |
ti-srebot
approved these changes
Mar 11, 2021
Member
Author
|
/merge |
Contributor
|
/run-all-tests |
Member
Author
|
/merge |
Contributor
|
@overvenus merge failed. |
Contributor
|
Your auto merge job has been accepted, waiting for:
|
Contributor
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 11, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #852 |
overvenus
pushed a commit
that referenced
this pull request
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Unify version and set max compatible via NextMajorVersion.
Check List
Tests
Code changes
Related changes
Release Note