This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Make Lightning S3 use force-path-style=true by default (#903)#922
Merged
ti-chi-bot merged 3 commits intoJul 6, 2021
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
kennytm
reviewed
Mar 24, 2021
Collaborator
|
/lgtm |
glorv
approved these changes
Jun 29, 2021
kennytm
approved these changes
Jun 29, 2021
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Collaborator
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: c413bcf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #903 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/922After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Lightning is different from BR and Dumpling that
force-path-styleis false by default. This is because both BR and Dumpling reads the storage URL through(*BackendOptions).ParseFromFlagswhich setsForcePathStyleto true:br/pkg/storage/s3.go
Line 203 in 0b223bc
but such adjustment is absent from Lightning.
What is changed and how it works?
We set the default
ForcePathStyleto true insidestorage.ParseBackendso Lightning, starting with the default backend options, will also useforce-path-style=trueby default.Also fixed the unit tests on Windows.
Check List
Tests
Code changes
Side effects
force-path-style=trueby default, instead offorce-path-style=false.Related changes
Release Note
Then importing from S3, Lightning now uses
force-path-style=trueby default, aligning with BR and Dumpling. To use the virtual host addressing style, explicitly set theforce-path-styleoption like:./tidb-lightning -d 's3://bucket/path?force-path-style=0&...'