Skip to content

sig-exec: promote b41sh to committer#330

Merged
AndreMouche merged 7 commits into
pingcap:masterfrom
qw4990:b41sh
Oct 29, 2020
Merged

sig-exec: promote b41sh to committer#330
AndreMouche merged 7 commits into
pingcap:masterfrom
qw4990:b41sh

Conversation

@qw4990
Copy link
Copy Markdown
Contributor

@qw4990 qw4990 commented Oct 28, 2020

Since @b41sh has contributed a lot to sig-exec, according to sig-exec roles-and-organization-management.md#promotion, we would like to promote him to our new committer, and his detailed contribution is shown below:

  1. contribute 40+ PRs to the executor,
  2. using go template to vectorized 24+ builtin functions (a medium task),
  3. support variable-setting hint SET_VAR (a medium task),
  4. implement the framework of tracing AggFun memory and help other contributors add memory trace for all aggregation functions (a hard task),
  5. help other contributors and review 25+ PRs.

Thanks for his contribution!! 😃 🎊

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 28, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ qw4990
❌ shenli
You have signed the CLA already but the status is still pending? Let us recheck it.

@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Oct 28, 2020

PTAL @SunRunAway @winkyao @AndreMouche

@AndreMouche AndreMouche requested a review from a team October 28, 2020 07:32
@zz-jason
Copy link
Copy Markdown
Member

LGTM

@winkyao
Copy link
Copy Markdown
Contributor

winkyao commented Oct 28, 2020

LGTM, congratulation.

@jackysp
Copy link
Copy Markdown
Contributor

jackysp commented Oct 28, 2020

LGTM

1 similar comment
@shenli
Copy link
Copy Markdown
Member

shenli commented Oct 28, 2020

LGTM

@AndreMouche AndreMouche merged commit 12b2c65 into pingcap:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants