Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

Quality reinforcement (6): fix unstable test cases#1153

Merged
lance6716 merged 20 commits into
masterfrom
fixTest
Oct 29, 2020
Merged

Quality reinforcement (6): fix unstable test cases#1153
lance6716 merged 20 commits into
masterfrom
fixTest

Conversation

@lance6716
Copy link
Copy Markdown
Collaborator

@lance6716 lance6716 commented Oct 13, 2020 •
edited
Loading

What problem does this PR solve?

fix unstable test cases in CI.

@lance6716 lance6716 added status/WIP This PR is still work in progress type/test Changes related to test cases labels Oct 13, 2020
@lance6716
Copy link
Copy Markdown
Collaborator Author

lance6716 commented Oct 13, 2020

will disable stress now, seems our daily PR could reveal enough unstable CI (more than we could fix)

@csuzhangxc
Copy link
Copy Markdown
Member

csuzhangxc commented Oct 15, 2020

/run-all-tests

for coverage

@lance6716 lance6716 added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Oct 27, 2020
@lance6716
Copy link
Copy Markdown
Collaborator Author

lance6716 commented Oct 27, 2020

/run-all-tests

csuzhangxc
csuzhangxc reviewed Oct 27, 2020
View reviewed changes
Comment thread tests/shardddl3/run.sh
csuzhangxc
csuzhangxc reviewed Oct 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 28, 2020
@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Oct 28, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 milestone Oct 28, 2020
GMHDBJD
GMHDBJD approved these changes Oct 29, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 29, 2020
@lance6716
Copy link
Copy Markdown
Collaborator Author

lance6716 commented Oct 29, 2020

/run-all-tests

etcd timeout

@lance6716 lance6716 merged commit 1e7d415 into master Oct 29, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 29, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1153 to release-2.0
5c04086 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 29, 2020
Merged
20 tasks
@ti-srebot
Copy link
Copy Markdown

ti-srebot commented Oct 29, 2020

cherry pick to release-2.0 in PR #1236

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 29, 2020
lance6716 pushed a commit that referenced this pull request Oct 29, 2020
@ti-srebot
cherry pick #1153 to release-2.0 (#1236)
5f456a3
@GMHDBJD GMHDBJD deleted the fixTest branch November 13, 2020 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked status/LGT2 Two reviewers already commented LGTM, ready for merge type/test Changes related to test cases

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lance6716 @csuzhangxc @ti-srebot @GMHDBJD