This repository was archived by the owner on Nov 24, 2023. It is now read-only.
Conversation
3 tasks
lance6716
added
needs-cherry-pick-release-2.0
lance6716
commented
Dec 23, 2020
|
|
||
| # resume manually | ||
| # this operation may not return 3 `"result": true`, because worker may | ||
| # - response too slowly to resume, so resume still see old error and waitOperationOk will return early |
Collaborator
Author
There was a problem hiding this comment.
that's not a "declarative command", and I think the right way of waitOperationOk of resuming is resuming at least once and see that result. Our persistent data in etcd may not support this change
GMHDBJD
reviewed
Jan 19, 2021
|
|
||
| if needSavePos { | ||
| err = r.SaveMeta(lastPos, lastGTID) | ||
| err = r.SaveMeta(lastPos, lastGTID.Clone()) |
Collaborator
There was a problem hiding this comment.
Possible performance regression. But I have no idea.
Collaborator
Author
There was a problem hiding this comment.
How about we merging this PR now? I met this DATA RACE again
Collaborator
Author
|
seems "some unit test using etcd jenkins" is failed because etcd too slow putting election key spends more than 1 second, so in the test sleeping 1 second and checking the leader is not enough |
Contributor
|
/lgtm |
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Jan 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
6 tasks
|
cherry pick to release-2.0 in PR #1402 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
pushed a commit
that referenced
this pull request
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?