Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

syncer: don't skip jobs from same event when comparing table checkpoint (#1752)#1781

Merged
ti-chi-bot merged 1 commit into
pingcap:release-2.0from
ti-chi-bot:cherry-pick-1752-to-release-2.0
Jun 17, 2021
Merged

syncer: don't skip jobs from same event when comparing table checkpoint (#1752)#1781
ti-chi-bot merged 1 commit into
pingcap:release-2.0from
ti-chi-bot:cherry-pick-1752-to-release-2.0

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #1752

What problem does this PR solve?

close #1751

after all_mode paused, we could see

MySQL [all_mode]> select * from t2;
+----+-------+---------------------+
| id | name  | ts                  |
+----+-------+---------------------+
|  1 | Arya  | 2021-06-05 18:01:52 |
|  2 | Bran  | 2021-05-11 10:01:05 |
|  3 | Sansa | 2021-06-05 18:01:52 |
| 10 | 10    | 2021-06-05 18:02:02 |
| 20 | 20    | 2021-06-05 18:02:02 |
| 30 | 30    | 2021-06-05 18:02:02 |
+----+-------+---------------------+
6 rows in set (0.001 sec)

MySQL [all_mode]> select * from t1;
+----+---------+---------------------+---------------------+
| id | name    | dt                  | ts                  |
+----+---------+---------------------+---------------------+
|  1 | ar"ya   | 2021-06-05 18:01:52 | 2021-06-05 18:01:52 |
|  2 | catelyn | 2021-05-11 10:01:05 | 2021-05-11 10:01:05 |
|  3 | lalala  | NULL                | 2021-06-05 18:01:52 |
| 10 | 10      | NULL                | 2021-06-05 18:02:01 |
| 30 | 30      | NULL                | 2021-06-05 18:02:02 |
+----+---------+---------------------+---------------------+
5 rows in set (0.001 sec)

t1 losts a row with id = 20 of https://github.com/pingcap/dm/pull/1752/files#diff-5cc7189b51f6219ea0ce1c9920f92f84cee41b3fee093894a72ca5ff1c615b4aR2

What is changed and how it works?

Check List

Tests

  • Integration test

Code changes

  • Has interface methods change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/L type/cherry-pick-for-release-2.0 labels Jun 17, 2021
@ti-chi-bot ti-chi-bot requested a review from lichunzhu June 17, 2021 03:17
@ti-chi-bot ti-chi-bot requested review from GMHDBJD and lance6716 June 17, 2021 03:17
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jun 17, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 17, 2021
@lance6716
Copy link
Copy Markdown
Collaborator

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member Author

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 38c3c2e

@ti-chi-bot ti-chi-bot merged commit e85bfd2 into pingcap:release-2.0 Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/L status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick-for-release-2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants