Skip to content

*: add tidb_ddl_distribute_reorg item to system-variables#12885

Merged
ti-chi-bot merged 11 commits into
pingcap:masterfrom
zimulala:zimuxia/dist-reorg
Feb 16, 2023
Merged

*: add tidb_ddl_distribute_reorg item to system-variables#12885
ti-chi-bot merged 11 commits into
pingcap:masterfrom
zimulala:zimuxia/dist-reorg

Conversation

@zimulala
Copy link
Copy Markdown
Contributor

@zimulala zimulala commented Feb 1, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add tidb_ddl_distribute_reorg to system-variables.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 1, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn February 1, 2023 06:24
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2023
@zimulala
Copy link
Copy Markdown
Contributor Author

zimulala commented Feb 1, 2023

PTAL @Benjamin2037 @Defined2014

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. v6.6 type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Feb 1, 2023
@TomShawn TomShawn requested a review from ran-huang February 1, 2023 07:36
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Co-authored-by: Hangjie Mo <mohangjie1995@gmail.com>
Comment thread system-variables.md Outdated
Co-authored-by: Benjamin2037 <benjamin2037@sina.com>
Comment thread system-variables.md
Comment thread system-variables.md Outdated
Copy link
Copy Markdown
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread system-variables.md
Comment thread system-variables.md Outdated
Comment thread system-variables.md
Comment thread system-variables.md Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2023
Comment thread system-variables.md Outdated
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 7, 2023
Comment thread system-variables.md Outdated
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Comment thread system-variables.md Outdated
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2023
ran-huang and others added 2 commits February 7, 2023 16:41
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
Copy link
Copy Markdown
Contributor

/verify

@ran-huang
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8a553c7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@ti-chi-bot ti-chi-bot merged commit df1269f into pingcap:master Feb 16, 2023
@zimulala zimulala deleted the zimuxia/dist-reorg branch February 16, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants