Skip to content

sql-stmt: update synopsis to ebnf diagrams for 6 statements#17211

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
lilin90:sql-ebnf
May 8, 2024
Merged

sql-stmt: update synopsis to ebnf diagrams for 6 statements#17211
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
lilin90:sql-ebnf

Conversation

@lilin90
Copy link
Copy Markdown
Member

@lilin90 lilin90 commented Apr 25, 2024

What is changed, added or deleted? (Required)

Update synopsis to ebnf diagrams for 6 SQL statements, to make it clearer, and easier to maintain

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-8.0 labels Apr 25, 2024
@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2024
@lilin90 lilin90 self-assigned this Apr 25, 2024
@lilin90 lilin90 requested a review from kennytm April 25, 2024 09:15
Comment thread sql-statements/sql-statement-show-indexes.md Outdated
Co-authored-by: kennytm <kennytm@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 29, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread sql-statements/sql-statement-split-region.md
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-08 06:58:54.720120063 +0000 UTC m=+1031688.477255621: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 8, 2024
@lilin90 lilin90 added the lgtm label May 8, 2024
@lilin90
Copy link
Copy Markdown
Member Author

lilin90 commented May 8, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 8, 2024
@ti-chi-bot ti-chi-bot Bot merged commit 62a8ea0 into pingcap:master May 8, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17283.

@lilin90 lilin90 deleted the sql-ebnf branch May 8, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants