Skip to content

statistics: update the note for sampling rate#17467

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
qiancai:update-desc-sampling-rate
Jun 4, 2024
Merged

statistics: update the note for sampling rate#17467
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
qiancai:update-desc-sampling-rate

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented May 29, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Removed the description about the 0 results of STATS_META after importing data, because the related issue is resolved in pingcap/tidb#48562 starting from v7.6.0.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2024
@qiancai qiancai added area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. ONCALL Relates to documentation oncall. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2024

@hawkingrei: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread statistics.md Outdated
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2024
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2024
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 4, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-04 06:16:39.148378639 +0000 UTC m=+3361952.905514205: ☑️ agreed by lance6716.
  • 2024-06-04 07:11:26.058341505 +0000 UTC m=+3365239.815477088: ☑️ agreed by Oreoxmt.

@qiancai qiancai removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jun 4, 2024
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Jun 4, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot merged commit ffb017e into pingcap:master Jun 4, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17553.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17554.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17555.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants