Skip to content

reference/performance: add follower-read doc#2019

Merged
lilin90 merged 23 commits into
pingcap:masterfrom
baiyuqing:master
Nov 20, 2019
Merged

reference/performance: add follower-read doc#2019
lilin90 merged 23 commits into
pingcap:masterfrom
baiyuqing:master

Conversation

@baiyuqing
Copy link
Copy Markdown
Contributor

@baiyuqing baiyuqing commented Nov 7, 2019 •
edited by lilin90
Loading

What is changed, added or deleted?

Add docs related to follower read

What is the related PR or file link(s)?

Which version does your change affect?

dev, v3.1

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 7, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@baiyuqing baiyuqing force-pushed the master branch 2 times, most recently from 4f2d9d9 to 480ae40 Compare November 7, 2019 05:18
@lilin90 lilin90 added type/refactor The issue belongs to a refactor work. website labels Nov 8, 2019
@lilin90 lilin90 requested a review from YiniXu9506 November 8, 2019 08:04
@lilin90 lilin90 added the DNM label Nov 8, 2019
@lilin90 lilin90 requested a review from zz-jason November 8, 2019 08:05
@lilin90 lilin90 added the v3.1 label Nov 8, 2019
@lilin90 lilin90 added translation/doing This PR’s assignee is translating this PR. contribution This PR is from a community contributor. and removed type/refactor The issue belongs to a refactor work. website labels Nov 10, 2019
@lilin90 lilin90 requested review from junlan-zhang and removed request for YiniXu9506 November 10, 2019 10:59
@lilin90 lilin90 requested review from lilin90 and removed request for junlan-zhang November 10, 2019 11:00
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Nov 10, 2019

@baiyuqing Thanks for your contribution! @zz-jason PTAL

zhangjinpeng87
zhangjinpeng87 reviewed Nov 11, 2019
View reviewed changes
Comment thread dev/reference/performance/follower-read.md Outdated
@ericsyh
Copy link
Copy Markdown
Contributor

ericsyh commented Nov 11, 2019

@baiyuqing Pls apply to the v3.1 also.

lilin90
lilin90 reviewed Nov 11, 2019
View reviewed changes
Comment thread dev/reference/performance/follower-read.md Outdated
Comment thread dev/reference/performance/follower-read.md Outdated
Comment thread dev/reference/performance/follower-read.md Outdated
Comment thread dev/reference/performance/follower-read.md Outdated
hicqu
hicqu reviewed Nov 12, 2019
View reviewed changes
Comment thread dev/reference/performance/follower-read.md Outdated
@hicqu
Copy link
Copy Markdown
Contributor

hicqu commented Nov 12, 2019

rest LGTM.

lilin90
lilin90 reviewed Nov 12, 2019
View reviewed changes
Comment thread dev/reference/performance/follower-read.md
Comment thread dev/reference/performance/follower-read.md Outdated
Comment thread dev/reference/performance/follower-read.md Outdated
zz-jason
zz-jason reviewed Nov 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 removed the DNM label Nov 20, 2019
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Nov 20, 2019 •
edited
Loading

@zz-jason I made some changes:

  • Optimize content organization
  • Remove unnecessary content for a file in documentation (not a blog article)
  • Update format and wording
  • Modify round robine to round robin
  • Add this new file to v3.1 and TOC.md

PTAL again~ Thanks!

@zz-jason
Copy link
Copy Markdown
Member

zz-jason commented Nov 20, 2019

@zz-jason I made some changes:

  • Optimize content organization
  • Remove unnecessary content for a file in documentation (not a blog article)
  • Update format and wording
  • Modify round robine to round robin
  • Add this new file to v3.1 and TOC.md

PTAL again~ Thanks!

Cool! The latest content LGTM.

lilin90
lilin90 approved these changes Nov 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit baf4ad4 into pingcap:master Nov 20, 2019
@lilin90 lilin90 added dev priority/P1 The issue has P1 priority. size/large Changes of a large size. labels Nov 20, 2019
@junlan-zhang junlan-zhang mentioned this pull request Nov 27, 2019
Merged
@junlan-zhang junlan-zhang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 27, 2019
@junlan-zhang junlan-zhang mentioned this pull request Dec 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 left review comments

@lilin90 lilin90 lilin90 approved these changes

+2 more reviewers

@zz-jason zz-jason zz-jason left review comments

@hicqu hicqu hicqu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@junlan-zhang junlan-zhang

Labels

contribution This PR is from a community contributor. priority/P1 The issue has P1 priority. size/large Changes of a large size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@baiyuqing @CLAassistant @lilin90 @ericsyh @hicqu @zz-jason @zhangjinpeng87 @junlan-zhang