Skip to content

how-to/maintain: refine BR doc description and organization#2088

Merged
lilin90 merged 12 commits into
pingcap:masterfrom
TomShawn:refine-br-language
Dec 5, 2019
Merged

how-to/maintain: refine BR doc description and organization#2088
lilin90 merged 12 commits into
pingcap:masterfrom
TomShawn:refine-br-language

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

What is changed, added or deleted?

Refine the BR document and update v3.1

What is the related PR or file link(s)?

#2084

Which version does your change affect?

dev, v3.1

@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Nov 29, 2019
@TomShawn TomShawn self-assigned this Nov 29, 2019
Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 2, 2019
@lilin90 lilin90 added the priority/P1 The issue has P1 priority. label Dec 3, 2019
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Dec 3, 2019

@3pointer PTAL, thanks~


2. 把解析出来的 SST 文件,根据表进行 `GroupBy` 聚合。

3. 根据 SST 文件的 Key Range 进行预切分 Region,使得每个 Region 对应一个 SST 文件。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. 根据 SST 文件的 Key Range 进行预切分 Region,使得每个 Region 对应一个 SST 文件。
3. 根据 SST 文件的 Key Range 进行预切分 Region,使得每个 Region 至少对应一个 SST 文件。


5. 找到该文件对应的 Region,发送下载文件的请求到对应的 TiKV 节点,并在下载成功后,发送加载请求。

TiKV 收到加载 SST 文件的请求后, 利用 Raft 机制保证加载 SST 数据的强一致性。在加载成功后,下载下来的 SST 文件会被异步删除。
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TiKV 收到加载 SST 文件的请求后, 利用 Raft 机制保证加载 SST 数据的强一致性。在加载成功后,下载下来的 SST 文件会被异步删除。
TiKV 收到加载 SST 文件的请求后利用 Raft 机制保证加载 SST 数据的强一致性。在加载成功后,下载下来的 SST 文件会被异步删除。

@@ -241,14 +183,14 @@ br restore table \

## 注意事项
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 使用限制?

- BR 只支持 TiDB 3.1 及以上版本。
- 如果在没有网络存储的集群上备份,在恢复前需要将所有备份下来的 SST 文件拷贝到各个 TiKV 节点上 `--storage` 指定的目录下。
- BR 只支持 TiDB v3.1 及以上版本。
- 如果备份的集群没有网络存储,在恢复前需要将所有备份的 SST 文件拷贝到各个 TiKV 节点上 `--storage` 指定的目录下。
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest moving this item to 恢复集群数据.

- 目前不支持 Partition Table 的备份恢复。
- 目前只支持在全新的集群上执行恢复操作。
- 如果备份时间可能超过设定的 GC lifetime(默认 10 分钟),则需要将 GC lifetime 调大
- 如果备份时间可能超过设定的 [`tikv_gc_life_time`](/dev/reference/garbage-collection/configuration.md#tikv_gc_life_time)(默认 `10m0s`),则需要将该参数调大
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this item to the backup section?

例如,将 `tikv_gc_life_time` 调整为 `720h`:

{{< copyable "sql" >}}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3pointer Can we take this item (为了加快数据恢复速度...) as one of the best practices section?

@@ -241,14 +183,14 @@ br restore table \

## 注意事项
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 使用限制?

Copy link
Copy Markdown
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread dev/how-to/maintain/backup-and-restore/br.md Outdated
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM


- BR 只支持 TiDB v3.1 及以上版本。
- TiDB 执行 DDL 期间不能执行备份操作。
- 目前不支持 Partition Table 的备份恢复。
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 目前不支持 Partition Table 的备份恢复
- 目前不支持分区表的备份恢复

"update mysql.tidb set variable_value='720h' where variable_name='tikv_gc_life_time'";
```

- 为了加快数据恢复速度,可以在恢复操作前,使用 pd-ctl 关闭与调度相关的 schedulers。恢复完成后,再重新添加这些 schedulers。
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 为了加快数据恢复速度,可以在恢复操作前,使用 pd-ctl 关闭与调度相关的 schedulers。恢复完成后,再重新添加这些 schedulers
- 为了加快数据恢复速度,可以在恢复操作前,使用 pd-ctl 关闭与调度相关的 scheduler。恢复完成后,再重新添加这些 scheduler

Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 changed the title maintain: refine language of br and update v3.1 how-to/maintain: refine language of br and update v3.1 Dec 5, 2019
@lilin90 lilin90 changed the title how-to/maintain: refine language of br and update v3.1 how-to/maintain: refine BR doc description and organization Dec 5, 2019
@lilin90 lilin90 merged commit 717423c into pingcap:master Dec 5, 2019
@TomShawn TomShawn deleted the refine-br-language branch December 5, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/P1 The issue has P1 priority. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants