Skip to content

*: remove tidb_batch_insert and tidb_batch_delete#2194

Merged
zz-jason merged 1 commit into
pingcap:masterfrom
jackysp:rm_batch
Jan 17, 2020
Merged

*: remove tidb_batch_insert and tidb_batch_delete#2194
zz-jason merged 1 commit into
pingcap:masterfrom
jackysp:rm_batch

Conversation

@jackysp
Copy link
Copy Markdown
Contributor

@jackysp jackysp commented Jan 17, 2020

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What is changed, added or deleted?

Adding warnings for tidb_batch_insert and tidb_batch_delete does not make the user clear the risks of them. Remove them.

What is the related PR or file link(s)?

  • Reference link(s):
  • This PR is to align with:
  • N/A (not applicable)

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Copy link
Copy Markdown
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit b483e9c into pingcap:master Jan 17, 2020
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Feb 4, 2020
@jackysp jackysp mentioned this pull request Feb 7, 2020
12 tasks
@lilin90 lilin90 added the size/small Changes of a small size. label Feb 11, 2020
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 11, 2020
@jackysp jackysp deleted the rm_batch branch March 18, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants