Skip to content

scripts: update verify links to fit current layout (#2284) #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yikeke merged 2 commits into from
Feb 24, 2020
Merged

scripts: update verify links to fit current layout (#2284) #2286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0b44ec
update verify links to fit current layout
cofyc Feb 24, 2020
cf3d8a3
Merge branch 'release-3.0' into release-3.0-acd74298fa10
yikeke Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/markdown-link-check.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
}
],
"replacementPatterns": [
{
"pattern": "^(?!(/<VERSION>/|/media/))",
"replacement": "/ERROR:link-must-start-with-slash-and-cannot-reference-files-in-other-version-directory:"
{
"pattern": "^(?!(/|/media/))",
"replacement": "/ERROR:link-must-start-with-slash:"
},
{
"comment": "prefix with repo root",
Expand Down
51 changes: 22 additions & 29 deletions scripts/verify-links.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,35 +39,28 @@ function in_array() {
}

# Check all directories starting with 'v\d.*' and dev.
for d in dev $(ls -d v[0-9]*); do
if in_array $d "${IGNORE_DIRS[@]}"; then
echo "info: directory $d skipped"
continue
fi
echo "info: checking links under $d directory..."
sed \
-e "s#<ROOT>#$ROOT#g" \
-e "s#<VERSION>#$d#g" \
scripts/markdown-link-check.tpl > $CONFIG_TMP
if [ -n "$VERBOSE" ]; then
cat $CONFIG_TMP
fi
# TODO simplify this if markdown-link-check can process multiple files together
while read -r tasks; do
for task in $tasks; do
(
output=$(markdown-link-check --color --config "$CONFIG_TMP" "$task" -q)
if [ $? -ne 0 ]; then
printf "$output" >> $ERROR_REPORT
fi
if [ -n "$VERBOSE" ]; then
echo "$output"
fi
) &
done
wait
done <<<"$(find "$d" -type f -name '*.md' | xargs -n 10)"
done
echo "info: checking links under $ROOT directory..."
sed \
-e "s#<ROOT>#$ROOT#g" \
scripts/markdown-link-check.tpl > $CONFIG_TMP
if [ -n "$VERBOSE" ]; then
cat $CONFIG_TMP
fi
# TODO simplify this if markdown-link-check can process multiple files together
while read -r tasks; do
for task in $tasks; do
(
output=$(markdown-link-check --color --config "$CONFIG_TMP" "$task" -q)
if [ $? -ne 0 ]; then
printf "$output" >> $ERROR_REPORT
fi
if [ -n "$VERBOSE" ]; then
echo "$output"
fi
) &
done
wait
done <<<"$(find "." -type f -not -path './node_modules/*' -name '*.md' | xargs -n 10)"

error_files=$(cat $ERROR_REPORT | grep 'FILE: ' | wc -l)
error_output=$(cat $ERROR_REPORT)
Expand Down