Skip to content

faq/tidb.md: update wording about transaction size limit#2314

Merged
sre-bot merged 8 commits into
pingcap:masterfrom
tiancaiamao:large-txn
Mar 3, 2020
Merged

faq/tidb.md: update wording about transaction size limit#2314
sre-bot merged 8 commits into
pingcap:masterfrom
tiancaiamao:large-txn

Conversation

@tiancaiamao
Copy link
Copy Markdown
Contributor

@tiancaiamao tiancaiamao commented Feb 26, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted?

Update transaction size description

What is the related PR or file link(s)?

TomShawn
TomShawn reviewed Feb 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor language edits

Comment thread faq/tidb.md Outdated
Comment thread faq/tidb.md Outdated
@TomShawn TomShawn self-assigned this Feb 26, 2020
@TomShawn TomShawn added dev translation/doing This PR’s assignee is translating this PR. v4.0 This PR/issue applies to TiDB v4.0. labels Feb 26, 2020
@tiancaiamao
Copy link
Copy Markdown
Contributor Author

tiancaiamao commented Feb 26, 2020

PTAL @coocood @TomShawn

See also pingcap/docs#1876

tiancaiamao and others added 2 commits February 26, 2020 21:23
@tiancaiamao @TomShawn
Update faq/tidb.md
924bf4e 
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@tiancaiamao @TomShawn
Update faq/tidb.md
1ca8f96 
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn assigned tiancaiamao and unassigned TomShawn Feb 26, 2020
@tiancaiamao tiancaiamao mentioned this pull request Feb 26, 2020
Merged
1 task
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 26, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Feb 26, 2020

LGTM

@tiancaiamao
Copy link
Copy Markdown
Contributor Author

tiancaiamao commented Feb 27, 2020

Tiny update, remove the description about 5000 statement limitation inside a transaction.
@coocood @TomShawn

@TomShawn TomShawn added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 27, 2020
@coocood
Copy link
Copy Markdown
Member

coocood commented Feb 27, 2020

LGTM

TomShawn
TomShawn reviewed Feb 27, 2020
View reviewed changes
Comment thread faq/tidb.md Outdated
@tiancaiamao @TomShawn
Update faq/tidb.md
cbe694d 
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@tiancaiamao
Copy link
Copy Markdown
Contributor Author

tiancaiamao commented Mar 3, 2020

PTAL @TomShawn

TomShawn
TomShawn approved these changes Mar 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Mar 3, 2020

/run-all-tests

@sre-bot sre-bot merged commit 4c857c5 into pingcap:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tiancaiamao tiancaiamao

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiancaiamao @TomShawn @coocood @sre-bot