Skip to content

sql/attributes: refine the language of auto random doc#2333

Merged
sre-bot merged 3 commits into
pingcap:masterfrom
TomShawn:typo-auto-random
Feb 28, 2020
Merged

sql/attributes: refine the language of auto random doc#2333
sre-bot merged 3 commits into
pingcap:masterfrom
TomShawn:typo-auto-random

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Feb 28, 2020

What is changed, added or deleted?

Refine the language of the AUTO_RANDOM document.

What is the related PR or file link(s)?

Important Notice:

If your changes apply to multiple TiDB documentation versions, to trigger the bot to cherry-pick this PR to other release branches, make sure you add labels such as:

  • needs-cherry-pick-3.0
  • needs-cherry-pick-3.1
  • needs-cherry-pick-2.1

@TomShawn TomShawn added dev translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0. labels Feb 28, 2020
@TomShawn TomShawn self-assigned this Feb 28, 2020
@TomShawn
Copy link
Copy Markdown
Contributor Author

@tangenta PTAL, thanks!

Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@junlan-zhang junlan-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread reference/sql/attributes/auto-random.md Outdated
```

在以上语句所建的表上执行大量未指定主键值的 `INSERT` 语句时,示例如下
在以上语句所建的表上执行大量未指定主键值的 `INSERT` 语句,示例如下
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
在以上语句所建的表上执行大量未指定主键值的 `INSERT` 语句,示例如下
在以上语句所建的表上执行大量未指定主键值的 `INSERT` 语句,示例如下

Comment thread reference/sql/attributes/auto-random.md Outdated
自动分配值的计算方式如下:

该行值在二进制形式下的最高 5 位(称为 shard bits)由当前事务的开始时间决定,剩下的位数按照自增的顺序分配
该行值在二进制形式下的最高五位(称为 shard bits)由当前事务的开始时间决定,剩下的位数分配到自增顺序的数值
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest 剩下的位数分配自增顺序的数值 or 剩下的位数按照自增顺序分配数值

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit e962ada into pingcap:master Feb 28, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to release-3.1 in PR #2334

@TomShawn TomShawn deleted the typo-auto-random branch February 28, 2020 05:38
TomShawn added a commit that referenced this pull request Feb 28, 2020
* sql/attributes: refine the language of auto random doc

* address comments

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants