how-to: add placement rule guide by disksing · Pull Request #2587 · pingcap/docs-cn

disksing · 2020-03-31T11:58:56Z

Signed-off-by: disksing i@disksing.com

What is changed, added or deleted? (Required)

add placement rules configuratoin guide

Which TiDB version(s) do your changes apply to? (Required)

master (the latest development version, including v4.0 changes for now)
v3.1 (TiDB 3.1 versions)
v3.0 (TiDB 3.0 versions)
v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

original PR #2246

This PR is translated from:
Other reference link(s):

Signed-off-by: disksing <i@disksing.com>

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Signed-off-by: disksing <i@disksing.com>

TomShawn · 2020-04-01T07:32:52Z

LGTM
@GregoryIan PTAL

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

IANTHEREAL · 2020-04-02T06:12:26Z

+pd-ctl config placement-rules show --group=pd --id=default
+```
+
+**查看 Region 2 所匹配的规则列表**


region 2 是什么？

IANTHEREAL · 2020-04-02T06:13:38Z

+
+以上操作会将 rule1、rule2 两条规则写入 PD，如果系统中已经存在 GroupID+ID 相同的规则，则会被覆盖。
+
+如果需要删除某条规则，只需要将规则的 `count` 置为 0 即可，对应 GroupID+ID 相同的规则会被删除。如下命令将删除 pd/rule2 这条规则：


能不能直接提供一条 delete 命令

也行，不过只能删一个，所以这个还是要保留，我觉得

好的，晚点可以加一个

IANTHEREAL · 2020-04-02T06:15:30Z

+
+> **注意：**
+>
+> DDL 等操作会导致 table ID 发生变化，需要同步更新对应的规则。


这个主意项挺关键的，要不要再命令行提示里面放提醒，真怕用户看不到这行

tidb-ctl 的输出也有提示

IANTHEREAL

LGTM

TomShawn

LGTM

* how-to: add placement rule document Signed-off-by: disksing <i@disksing.com> * minor update Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update placement-rules.md * Update placement-rules.md * refine format and language * fix a typo Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ian <ArGregoryIan@gmail.com> Co-authored-by: TomShawn <1135243111@qq.com>

sre-bot · 2020-04-02T09:56:00Z

cherry pick to release-3.1 in PR #2610

* how-to: add placement rule document Signed-off-by: disksing <i@disksing.com> * minor update Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update placement-rules.md * Update placement-rules.md * refine format and language * fix a typo Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ian <ArGregoryIan@gmail.com> Co-authored-by: TomShawn <1135243111@qq.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ian <ArGregoryIan@gmail.com> Co-authored-by: TomShawn <1135243111@qq.com>

* how-to: add placement rule document Signed-off-by: disksing <i@disksing.com> * minor update Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update placement-rules.md * Update placement-rules.md * refine format and language * fix a typo Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ian <ArGregoryIan@gmail.com> Co-authored-by: TomShawn <1135243111@qq.com>

disksing added 2 commits March 31, 2020 19:47

how-to: add placement rule document

b9fbe96

Signed-off-by: disksing <i@disksing.com>

minor update

c7d8353

Signed-off-by: disksing <i@disksing.com>

disksing added the needs-cherry-pick-3.1 label Mar 31, 2020

disksing requested review from IANTHEREAL and TomShawn March 31, 2020 11:58

TomShawn added translation/doing This PR’s assignee is translating this PR. v4.0 This PR/issue applies to TiDB v4.0. labels Mar 31, 2020

TomShawn assigned ran-huang Mar 31, 2020

TomShawn reviewed Apr 1, 2020

View reviewed changes

disksing and others added 10 commits April 1, 2020 12:54

Update how-to/configure/placement-rules.md

34e8cd2

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update how-to/configure/placement-rules.md

1aa5bfe

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update how-to/configure/placement-rules.md

4fb46ff

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update how-to/configure/placement-rules.md

edd324d

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update how-to/configure/placement-rules.md

53a9f7d

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update how-to/configure/placement-rules.md

a0cbab7

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update how-to/configure/placement-rules.md

ae9035d

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update how-to/configure/placement-rules.md

7b09e12

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

address comment

7f7c1b2

Signed-off-by: disksing <i@disksing.com>

Merge branch 'master' into placement-rules

fa4617a

TomShawn reviewed Apr 2, 2020

View reviewed changes

Comment thread how-to/configure/placement-rules.md Outdated

Update how-to/configure/placement-rules.md

7764f11

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

IANTHEREAL reviewed Apr 2, 2020

View reviewed changes

IANTHEREAL and others added 4 commits April 2, 2020 14:16

Merge branch 'master' into placement-rules

d75c121

Update placement-rules.md

f7fa3e7

Merge branch 'master' into placement-rules

46d7985

Update placement-rules.md

6c0740d

IANTHEREAL approved these changes Apr 2, 2020

View reviewed changes

TomShawn added 2 commits April 2, 2020 17:39

refine format and language

ca1f509

fix a typo

6742f61

TomShawn approved these changes Apr 2, 2020

View reviewed changes

TomShawn merged commit fa0ef5d into pingcap:master Apr 2, 2020

sre-bot mentioned this pull request Apr 2, 2020

how-to: add placement rule guide (#2587) #2610

Merged

4 tasks

TomShawn assigned TomShawn and unassigned ran-huang Apr 3, 2020

disksing deleted the placement-rules branch April 3, 2020 03:09

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 4, 2020

TomShawn mentioned this pull request Apr 4, 2020

how-to: add placement rule guide pingcap/docs#2171

Merged

5 tasks

sre-bot mentioned this pull request Apr 7, 2020

how-to: add placement rule guide (#2171) pingcap/docs#2185

Merged

5 tasks

sre-bot mentioned this pull request Jun 11, 2020

how-to: add placement rule guide (#2171) pingcap/docs#2810

Merged

5 tasks


		以上操作会将 rule1、rule2 两条规则写入 PD，如果系统中已经存在 GroupID+ID 相同的规则，则会被覆盖。

		如果需要删除某条规则，只需要将规则的 `count` 置为 0 即可，对应 GroupID+ID 相同的规则会被删除。如下命令将删除 pd/rule2 这条规则：

Conversation

disksing commented Mar 31, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomShawn commented Apr 1, 2020

Uh oh!

Uh oh!

IANTHEREAL Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

disksing Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

IANTHEREAL Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

disksing Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

IANTHEREAL Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

IANTHEREAL Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

disksing Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

IANTHEREAL left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

sre-bot commented Apr 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants