how-to/deploy: add TiFlash to TiUP deployment by superlzs0476 · Pull Request #2662 · pingcap/docs-cn

superlzs0476 · 2020-04-08T13:48:11Z

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

superlzs0476 · 2020-04-08T13:52:26Z

@lilin90 @ilovesoup @cocoyi17 PTAL

marsishandsome · 2020-04-09T03:11:10Z

-> 无需手动创建 tidb 用户，TiUP cluster 组件会在部署主机上自动创建该用户。可以自定义用户，也可以和中控机的用户保持一致。
+> - 无需手动创建 tidb 用户，TiUP cluster 组件会在部署主机上自动创建该用户。可以自定义用户，也可以和中控机的用户保持一致。
+> 
+> - [部署 Tiflash](https://pingcap.com/docs-cn/dev/reference/tiflash/deploy/) 需要开启 `replication.enable-placement-rules` ，以开启 PD 的 [Placement Rules](https://pingcap.com/docs-cn/dev/how-to/configure/placement-rules/) 功能。


同一个文档内部链接是不是用 /reference/tiflash/deploy 就可以了？

是的，内链统一用相对链接哈，方便 cherry-pick： @superlzs0476

https://pingcap.com/docs-cn/dev/reference/tiflash/deploy/ -> /reference/tiflash/deploy.md

https://pingcap.com/docs-cn/dev/how-to/configure/placement-rules/ -> /how-to/configure/placement-rules.md

没明白，你来提一个 suggestion 我来点赞吧

marsishandsome · 2020-04-09T03:14:13Z

  - host: 10.0.1.3
+tiflash_servers:
+  - host: 10.0.1.10
+    # data_dir: /data1/tiflash/data,/data2/tiflash/data


其他组件的配置的注释好像都是从 https://github.com/pingcap-incubator/tiup-cluster/blob/master/topology.example.yaml 拷贝过来

tiflash是不是也可以拷贝过来？

# ssh_port: 22 # tcp_port: 9000 # http_port: 8123 # flash_service_port: 3930 # flash_proxy_port: 20170 # flash_proxy_status_port: 20292 # metrics_port: 8234 # deploy_dir: deploy/tiflash-9000 # data_dir: deploy/tiflash-9000/data # log_dir: deploy/tiflash-9000/log # numa_node: "0,1" # # Config is used to overwrite the `server_configs.tiflash` values # config: # logger: # level: "info" # learner_config: # log-level: "info"

提供一般参数介绍吧，这么多参数，Tiflash 的部署文档里面都没有。

Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com>

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com>

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

This reverts commit 0460005.

into pr/2662

yikeke

LGTM

marsishandsome

LGTM

marsishandsome

LGTM

yikeke · 2020-04-09T04:42:26Z

 >
 > - tiflash_servers 实例级别配置 `"-host"` 目前只支持 IP，不支持域名。
+>
+> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#常见部署问题)。


Suggested change

> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#常见部署问题)。

> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#tiflash-参数)。

yikeke · 2020-04-09T04:42:41Z

 >
 > - tiflash_servers 实例级别配置 `"-host"` 目前只支持 ip，不支持域名。
+>
+> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#常见部署问题)。


Suggested change

> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#常见部署问题)。

> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#tiflash-参数)。

yikeke · 2020-04-09T04:42:50Z

 >
 > - tiflash_servers 实例级别配置 `"-host"` 目前只支持 IP，不支持域名。
+>
+> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#常见部署问题)。


Suggested change

> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#常见部署问题)。

> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#tiflash-参数)。

yikeke · 2020-04-09T04:44:23Z

 | 实例 | data_dir | 继承 global 配置 | 数据目录 |
 | 实例 | log_dir | 继承 global 配置 | 日志目录 |

+


Suggested change

Multiple blanks will fail the CI.

* add module of deploy topology configuration for Tiflash * fix typo: tomestone -> tombstone * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Revert "fix typo: tomestone -> tombstone" This reverts commit 0460005. * Update how-to/deploy/orchestrated/tiup.md * FIX CI * add module of deploy topology configuration for Tiflash * add module of deploy topology configuration for Tiflash * refine format and content Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

sre-bot · 2020-04-09T06:29:28Z

cherry pick to release-4.0 in PR #2673

* add module of deploy topology configuration for Tiflash * fix typo: tomestone -> tombstone * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Revert "fix typo: tomestone -> tombstone" This reverts commit 0460005. * Update how-to/deploy/orchestrated/tiup.md * FIX CI * add module of deploy topology configuration for Tiflash * add module of deploy topology configuration for Tiflash * refine format and content Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: lzs <43946384+superlzs0476@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

* add module of deploy topology configuration for Tiflash * fix typo: tomestone -> tombstone * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Revert "fix typo: tomestone -> tombstone" This reverts commit 0460005. * Update how-to/deploy/orchestrated/tiup.md * FIX CI * add module of deploy topology configuration for Tiflash * add module of deploy topology configuration for Tiflash * refine format and content Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

superlzs0476 added 10 commits October 1, 2019 19:16

Merge branch 'master' of github.com:pingcap/docs-cn

8af2abd

Merge branch 'master' of github.com:pingcap/docs-cn

dad2cc3

Merge remote-tracking branch 'upstream/master'

2522c5b

Merge branch 'master' of github.com:pingcap/docs-cn

dcb74cf

Merge branch 'master' of github.com:pingcap/docs-cn

89db6ca

Merge remote-tracking branch 'upstream/master'

7272fcf

Merge remote-tracking branch 'upstream/master'

5ace768

Merge remote-tracking branch 'upstream/master'

a5a5d42

Merge remote-tracking branch 'upstream/master'

4f56b72

add module of deploy topology configuration for Tiflash

00a35cf

TomShawn requested a review from yikeke April 9, 2020 02:22

yikeke requested a review from ilovesoup April 9, 2020 02:47

fix typo: tomestone -> tombstone

0460005

marsishandsome reviewed Apr 9, 2020

View reviewed changes

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

yikeke reviewed Apr 9, 2020

View reviewed changes

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Apr 9, 2020

yikeke self-assigned this Apr 9, 2020

marsishandsome reviewed Apr 9, 2020

View reviewed changes

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

superlzs0476 and others added 6 commits April 9, 2020 11:37

Update how-to/deploy/orchestrated/tiup.md

6e4c2c8

Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com>

Update how-to/deploy/orchestrated/tiup.md

7e1cfaf

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Update how-to/deploy/orchestrated/tiup.md

27ae778

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Update how-to/deploy/orchestrated/tiup.md

149eba8

Co-Authored-By: Liangliang Gu <marsishandsome@gmail.com>

Update how-to/deploy/orchestrated/tiup.md

6c6d14f

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Update how-to/deploy/orchestrated/tiup.md

9505c66

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

yikeke reviewed Apr 9, 2020

View reviewed changes

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

yikeke and others added 2 commits April 9, 2020 11:44

Revert "fix typo: tomestone -> tombstone"

372503d

This reverts commit 0460005.

Update how-to/deploy/orchestrated/tiup.md

0f7d229

Merge branch 'deploy-tiflash' of https://github.com/superlzs0476/docs-cn

f107dad

into pr/2662

yikeke approved these changes Apr 9, 2020

View reviewed changes

Merge branch 'master' into deploy-tiflash

d6e263c

marsishandsome approved these changes Apr 9, 2020

View reviewed changes

yikeke reviewed Apr 9, 2020

View reviewed changes

Comment thread how-to/deploy/orchestrated/tiup.md Outdated

yikeke and others added 2 commits April 9, 2020 11:58

FIX CI

095e4f2

add module of deploy topology configuration for Tiflash

9bfd345

marsishandsome approved these changes Apr 9, 2020

View reviewed changes

yikeke reviewed Apr 9, 2020

View reviewed changes

superlzs0476 and others added 3 commits April 9, 2020 12:53

add module of deploy topology configuration for Tiflash

4106581

refine format and content

99d3dfc

Merge branch 'master' into deploy-tiflash

0ba79ce

yikeke merged commit 18d42b4 into pingcap:master Apr 9, 2020

sre-bot mentioned this pull request Apr 9, 2020

How-to:/deploy/tiup.md for deploy tiflash (#2662) #2673

Merged

5 tasks

lilin90 changed the title ~~How-to:/deploy/tiup.md for deploy tiflash~~ how-to/deploy: add TiFlash to TiUP deployment Apr 9, 2020

yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 9, 2020

superlzs0476 deleted the deploy-tiflash branch April 10, 2020 05:35

	> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#常见部署问题)。
	> - Tiflash 具体的参数配置介绍请见[常见部署问题 Tiflash 参数配置](#tiflash-参数)。

		\| 实例 \| data_dir \| 继承 global 配置 \| 数据目录 \|
		\| 实例 \| log_dir \| 继承 global 配置 \| 日志目录 \|

Conversation

superlzs0476 commented Apr 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

superlzs0476 commented Apr 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yikeke left a comment

Choose a reason for hiding this comment

Uh oh!

marsishandsome left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marsishandsome left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sre-bot commented Apr 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

superlzs0476 commented Apr 8, 2020 •

edited

Loading