Skip to content

refine ticdc open protocol doc#2763

Merged
sre-bot merged 5 commits into
pingcap:masterfrom
zier-one:ticdc_open_protocol
Apr 16, 2020
Merged

refine ticdc open protocol doc#2763
sre-bot merged 5 commits into
pingcap:masterfrom
zier-one:ticdc_open_protocol

Conversation

@zier-one
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

add examples for column type

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@zier-one zier-one requested a review from TomShawn April 15, 2020 09:32
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Apr 15, 2020
@TomShawn TomShawn self-assigned this Apr 15, 2020
Comment thread reference/tools/ticdc/column-ddl-type.md Outdated
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 15, 2020
leoppro and others added 2 commits April 15, 2020 17:52
@TomShawn
Copy link
Copy Markdown
Contributor

LGTM
@leoppro Please involve a technical review.

@zier-one zier-one requested a review from amyangfei April 15, 2020 10:30
Copy link
Copy Markdown
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit f0c7160 into pingcap:master Apr 16, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 16, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-4.0 in PR #2775

TomShawn pushed a commit that referenced this pull request Apr 16, 2020
Co-authored-by: leoppro <zhaoyilin@pingcap.com>
@zier-one zier-one deleted the ticdc_open_protocol branch April 16, 2020 03:12
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants