Skip to content

get-started: fix some descriptions and typos in tiup quick start doc#2813

Merged
yikeke merged 5 commits into
pingcap:masterfrom
yikeke:fix-quick-start-doc
Apr 18, 2020
Merged

get-started: fix some descriptions and typos in tiup quick start doc#2813
yikeke merged 5 commits into
pingcap:masterfrom
yikeke:fix-quick-start-doc

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Apr 18, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

fix some descriptions and typos in tiup quick start doc

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested a review from superlzs0476 April 18, 2020 04:59
@yikeke yikeke added needs-cherry-pick-4.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Apr 18, 2020
@yikeke yikeke requested a review from ran-huang April 18, 2020 05:01
@yikeke yikeke mentioned this pull request Apr 18, 2020
Merged
5 tasks
superlzs0476
superlzs0476 approved these changes Apr 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Apr 18, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2020
@yikeke yikeke merged commit a02c5ba into pingcap:master Apr 18, 2020
@yikeke yikeke deleted the fix-quick-start-doc branch April 18, 2020 13:11
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 18, 2020
@yikeke @sre-bot
get-started: fix some descriptions and typos in tiup quick start doc (p…
94299ed 
…ingcap#2813)

* get-started: fix some descriptions and typos in tiup quick start doc

* fix a grammar mistake

* fix backticks format

* change 登陆 -> 登录

* update tiup deploy
@sre-bot sre-bot mentioned this pull request Apr 18, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 18, 2020

cherry pick to release-4.0 in PR #2814

yikeke added a commit that referenced this pull request Apr 18, 2020
@sre-bot @yikeke
get-started: fix some descriptions and typos in tiup quick start doc (#…
8d1637e 
…2813) (#2814)

* get-started: fix some descriptions and typos in tiup quick start doc

* fix a grammar mistake

* fix backticks format

* change 登陆 -> 登录

* update tiup deploy

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@yikeke @rleungx
get-started: fix some descriptions and typos in tiup quick start doc (p…
9e6408d 
…ingcap#2813)

* get-started: fix some descriptions and typos in tiup quick start doc

* fix a grammar mistake

* fix backticks format

* change 登陆 -> 登录

* update tiup deploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ran-huang ran-huang Awaiting requested review from ran-huang

1 more reviewer

@superlzs0476 superlzs0476 superlzs0476 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yikeke @sre-bot @superlzs0476