Skip to content

sql, toc: refine character set and collation document (#2884)#2928

Merged
TomShawn merged 1 commit into
pingcap:release-4.0from
sre-bot:release-4.0-4eddc8d15ee7
Apr 29, 2020
Merged

sql, toc: refine character set and collation document (#2884)#2928
TomShawn merged 1 commit into
pingcap:release-4.0from
sre-bot:release-4.0-4eddc8d15ee7

Conversation

@sre-bot
Copy link
Copy Markdown
Contributor

@sre-bot sre-bot commented Apr 29, 2020

cherry-pick #2884 to release-4.0


What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

* sql, toc: refine character set and collation document

* address comments

* address comments

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot sre-bot added type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/enhancement The issue or PR belongs to an enhancement. labels Apr 29, 2020
@sre-bot sre-bot requested review from wjhuang2016 and yikeke April 29, 2020 13:16
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit aaec265 into pingcap:release-4.0 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants