Skip to content

sql: fix config name in collation doc#2946

Merged
TomShawn merged 2 commits into
pingcap:masterfrom
TomShawn:change-config-name
May 8, 2020
Merged

sql: fix config name in collation doc#2946
TomShawn merged 2 commits into
pingcap:masterfrom
TomShawn:change-config-name

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented May 1, 2020

What is changed, added or deleted? (Required)

Fix the incorrect configuration name in the Collation document.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels May 1, 2020
@TomShawn TomShawn requested a review from wjhuang2016 May 1, 2020 02:33
@TomShawn TomShawn self-assigned this May 1, 2020
Copy link
Copy Markdown
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 3, 2020

@wjhuang2016, PTAL.

4 similar comments
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 3, 2020

@wjhuang2016, PTAL.

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 5, 2020

@wjhuang2016, PTAL.

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 5, 2020

@wjhuang2016, PTAL.

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

@wjhuang2016, PTAL.

@TomShawn TomShawn merged commit dcc2a5d into pingcap:master May 8, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
Co-authored-by: wjHuang <huangwenjun1997@gmail.com>
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

cherry pick to release-4.0 in PR #2992

@TomShawn TomShawn deleted the change-config-name branch May 10, 2020 00:56
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels May 12, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
Co-authored-by: wjHuang <huangwenjun1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants