Skip to content

br: add incremental recover/backup.#2985

Merged
sre-bot merged 13 commits into
pingcap:masterfrom
YuJuncen:br-add-increment
May 15, 2020
Merged

br: add incremental recover/backup.#2985
sre-bot merged 13 commits into
pingcap:masterfrom
YuJuncen:br-add-increment

Conversation

@YuJuncen
Copy link
Copy Markdown
Contributor

@YuJuncen YuJuncen commented May 8, 2020

What is changed, added or deleted? (Required)

I added how-to of the incremental backup/restore to br.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 8, 2020

CLA assistant check
All committers have signed the CLA.

Comment thread reference/tools/br/br.md Outdated
Comment thread reference/tools/br/br.md
以上命令会备份 `[LAST_BACKUP_TS, current PD timestamp)` 之间的增量数据;注意你可以使用 `validate` 指令获取上一次备份的时间戳。

在增量恢复的时候,使用 BR 的方法和普通的恢复并无二样;只不过需要注意恢复增量数据的时候,需要保证备份时指定的 last backup ts 之前备份的数据已经全部恢复到目标集群。

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以加一段原理描述,增量备份时候会备份[LAST_BACKUP_TS, current PD timestamp)之间的 DDL,然后恢复时候,会首先执行这些 DDL。

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 9, 2020

@YuJuncen Does this PR apply to v3.1?

@TomShawn TomShawn added status/require-change Needs the author to address comments. translation/doing This PR’s assignee is translating this PR. labels May 9, 2020
@TomShawn TomShawn self-requested a review May 9, 2020 07:12
@YuJuncen
Copy link
Copy Markdown
Contributor Author

YuJuncen commented May 9, 2020

@YuJuncen Does this PR apply to v3.1?

It would be OK to take this PR to v3.1. @TomShawn

@TomShawn TomShawn added needs-cherry-pick-3.1 status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels May 9, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 11, 2020

@YuJuncen, please update your pull request.

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 11, 2020

@3pointer, @TomShawn, PTAL.

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels May 11, 2020
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3pointer PTAL again

Comment thread reference/tools/br/br.md Outdated
Comment thread reference/tools/br/br.md Outdated
Comment thread reference/tools/br/br.md Outdated
Comment thread reference/tools/br/br.md Outdated
YuJuncen and others added 2 commits May 11, 2020 17:22
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

LGTM

@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label May 12, 2020
@TomShawn TomShawn added status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. labels May 12, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 13, 2020

@3pointer, @TomShawn, PTAL.

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 13, 2020

@YuJuncen, please update your pull request.

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 15, 2020

@3pointer, @TomShawn, PTAL.

Copy link
Copy Markdown
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@toutdesuite toutdesuite added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit ad9a4a5 into pingcap:master May 15, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 15, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 15, 2020

cherry pick to release-3.1 in PR #3120

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 15, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 15, 2020

cherry pick to release-4.0 in PR #3121

TomShawn pushed a commit that referenced this pull request May 15, 2020
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
@TomShawn TomShawn self-requested a review May 31, 2020 04:01
@yikeke yikeke assigned toutdesuite and unassigned ran-huang Jun 1, 2020
@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants