Skip to content

how-to/secure: remove some week cipher suits#2998

Merged
sre-bot merged 2 commits into
pingcap:masterfrom
lysu:dev-remove-week-cipher-suit
May 8, 2020
Merged

how-to/secure: remove some week cipher suits#2998
sre-bot merged 2 commits into
pingcap:masterfrom
lysu:dev-remove-week-cipher-suit

Conversation

@lysu
Copy link
Copy Markdown
Contributor

@lysu lysu commented May 8, 2020

What is changed, added or deleted? (Required)

remove some week cipher suits from docs

(most of them are removed in new openssl, so user cannot use them even if go support that)

fixes #2996

Which TiDB version(s) do your changes apply to? (Required)

4.0
3.1
3.0

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

#2996

  • This PR is translated from:
  • Other reference link(s):

This change is Reviewable

@lysu lysu requested a review from jackysp May 8, 2020 12:25
Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label May 8, 2020
@TomShawn TomShawn self-assigned this May 8, 2020
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label May 8, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

Your auto merge job has been accepted, waiting for:

  • 2977

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit 9bfe90d into pingcap:master May 8, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

cherry pick to release-3.0 in PR #3003

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

cherry pick to release-3.1 in PR #3004

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 8, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 8, 2020

cherry pick to release-4.0 in PR #3005

TomShawn pushed a commit that referenced this pull request May 9, 2020
* cherry pick #2998 to release-3.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* address conflict:

tidb 3.0's goland also support TLS1.3 and three new 1.3 cipher suit

Co-authored-by: lysu <sulifx@gmail.com>
@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete cipher suites which are not working

5 participants