Skip to content

how-to/deploy: fix typos#3113

Merged
sre-bot merged 2 commits into
pingcap:release-4.0from
glkappe:patch-11
May 15, 2020
Merged

how-to/deploy: fix typos#3113
sre-bot merged 2 commits into
pingcap:release-4.0from
glkappe:patch-11

Conversation

@glkappe
Copy link
Copy Markdown
Contributor

@glkappe glkappe commented May 15, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@sre-bot sre-bot added the contribution This PR is from a community contributor. label May 15, 2020
@TomShawn TomShawn requested a review from superlzs0476 May 15, 2020 06:06
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels May 15, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 15, 2020 •
edited
Loading

@glkappe Thanks for your contribution! If this PR applies to dev and v4.0, it is recommended to create a PR based on the master branch (dev) and cherry-pick the change to v4.0 (we cannot do it the other way around). Would you mind creating another PR to apply the change to the master branch?

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 15, 2020

LGTM

@TomShawn TomShawn changed the title 描述错误 how-to/deploy: fix a typo May 15, 2020
@TomShawn TomShawn changed the title how-to/deploy: fix a typo how-to/deploy: fix typos May 15, 2020
@glkappe glkappe mentioned this pull request May 15, 2020
Merged
5 tasks
superlzs0476
superlzs0476 approved these changes May 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6469e4e into pingcap:release-4.0 May 15, 2020
@TomShawn TomShawn self-requested a review May 31, 2020 04:01
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 19, 2020
@yikeke yikeke assigned ran-huang and unassigned toutdesuite Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomShawn TomShawn Awaiting requested review from TomShawn

1 more reviewer

@superlzs0476 superlzs0476 superlzs0476 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-huang ran-huang

Labels

contribution This PR is from a community contributor. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@glkappe @TomShawn @sre-bot @superlzs0476 @toutdesuite @yikeke @ran-huang