Skip to content

config: update default path of temp-storage-path#3142

Merged
TomShawn merged 4 commits into
pingcap:masterfrom
hsqlu:doc-temp-storage
May 29, 2020
Merged

config: update default path of temp-storage-path#3142
TomShawn merged 4 commits into
pingcap:masterfrom
hsqlu:doc-temp-storage

Conversation

@hsqlu
Copy link
Copy Markdown
Contributor

@hsqlu hsqlu commented May 18, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Changed the default value of tmp-storage-path.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

hsqlu added 2 commits May 18, 2020 20:36
@hsqlu
Update documentation
ef1bcf1 
Signed-off-by: Qiannan Lyu <lvqiannan@gmail.com>
@hsqlu
Merge branch 'master' into doc-temp-storage
b8d1949
@sre-bot sre-bot added the contribution This PR is from a community contributor. label May 18, 2020
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 18, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hsqlu
Copy link
Copy Markdown
Contributor Author

hsqlu commented May 18, 2020

@SunRunAway PTAL

@TomShawn TomShawn requested review from SunRunAway and TomShawn May 19, 2020 02:09
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 and removed size/small Changes of a small size. labels May 19, 2020
@TomShawn TomShawn changed the title config: temp-storage-path default path update config: update default path of temp-storage-path May 19, 2020
@toutdesuite
Copy link
Copy Markdown
Contributor

toutdesuite commented May 19, 2020

Because this week is Document Special Week, the merge button is temporarily disabled, so we can only merge this PR until the end of the Special Week (presumably this Friday night). Is it acceptable for you? @hsqlu

SunRunAway
SunRunAway reviewed May 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2020
@hsqlu
Copy link
Copy Markdown
Contributor Author

hsqlu commented May 19, 2020

@toutdesuite Sure, no problem.

@TomShawn TomShawn assigned hsqlu and unassigned toutdesuite May 20, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 20, 2020
@hsqlu hsqlu mentioned this pull request May 20, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 21, 2020

@SunRunAway, @TomShawn, PTAL.

2 similar comments
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 23, 2020

@SunRunAway, @TomShawn, PTAL.

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 26, 2020

@SunRunAway, @TomShawn, PTAL.

TomShawn
TomShawn approved these changes May 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. labels May 28, 2020
@TomShawn TomShawn merged commit b2335d4 into pingcap:master May 29, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 29, 2020
@hsqlu @yikeke
@TomShawn @sre-bot
Update documentation (pingcap#3142)
be580b9 
Signed-off-by: Qiannan Lyu <lvqiannan@gmail.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request May 29, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented May 29, 2020

cherry pick to release-4.0 in PR #3402

sre-bot added a commit that referenced this pull request May 29, 2020
@sre-bot
config: update default path of temp-storage-path (#3142) (#3402)
92647e4
@sre-bot sre-bot mentioned this pull request May 29, 2020
Merged
5 tasks
@TomShawn TomShawn self-requested a review May 31, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomShawn TomShawn Awaiting requested review from TomShawn

1 more reviewer

@SunRunAway SunRunAway SunRunAway left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hsqlu hsqlu

Labels

contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hsqlu @CLAassistant @toutdesuite @sre-bot @SunRunAway @TomShawn @yikeke