Skip to content

Add syntax gram of load stats#3340

Merged
yikeke merged 5 commits into
pingcap:masterfrom
qw4990:load-stats
May 26, 2020
Merged

Add syntax gram of load stats#3340
yikeke merged 5 commits into
pingcap:masterfrom
qw4990:load-stats

Conversation

@qw4990
Copy link
Copy Markdown
Contributor

@qw4990 qw4990 commented May 25, 2020

What is changed, added or deleted? (Required)

Add syntax gram of load stats

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • This PR is translated from:
  • Other reference link(s):

@qw4990 qw4990 added the special-week PR from Document Special Week. label May 25, 2020
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented May 25, 2020

Please fix the lint.

zimulala
zimulala reviewed May 26, 2020
View reviewed changes
Comment thread sql-statements/sql-statement-load-stats.md Outdated
Comment thread sql-statements/sql-statement-load-stats.md
@yikeke yikeke self-requested a review May 26, 2020 05:26
@yikeke yikeke added status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels May 26, 2020
yikeke
yikeke reviewed May 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve comments. @qw4990

Rest LGTM

@yikeke yikeke added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels May 26, 2020
qw4990 and others added 2 commits May 26, 2020 13:53
zimulala
zimulala approved these changes May 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2020
@yikeke yikeke merged commit 59e5e8b into pingcap:master May 26, 2020
@qw4990 qw4990 mentioned this pull request May 27, 2020
Merged
5 tasks
This was referenced Jun 17, 2020
Merged
Merged
Merged
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. duplicate Issues or pull requests already exists. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 19, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 19, 2020

duplicate with #3362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes

+1 more reviewer

@yikeke yikeke yikeke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

duplicate Issues or pull requests already exists. special-week PR from Document Special Week. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qw4990 @bb7133 @yikeke @zimulala