Skip to content

Update mysql-compatibility.md#3436

Merged
sre-bot merged 2 commits into
release-4.0from
wjhuang2016-patch-3
Jun 2, 2020
Merged

Update mysql-compatibility.md#3436
sre-bot merged 2 commits into
release-4.0from
wjhuang2016-patch-3

Conversation

@wjhuang2016
Copy link
Copy Markdown
Member

@wjhuang2016 wjhuang2016 commented Jun 1, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Invisible index is not supported in 4.0

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

bb7133
bb7133 reviewed Jun 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 1, 2020

@wjhuang2016 Is master the only version that supports invisible index?

@TomShawn TomShawn self-requested a review June 1, 2020 11:23
@TomShawn TomShawn self-assigned this Jun 1, 2020
@TomShawn TomShawn added status/LGT1 Indicates that a PR has LGTM 1. translation/doing This PR’s assignee is translating this PR. labels Jun 1, 2020
@wjhuang2016
Copy link
Copy Markdown
Member Author

wjhuang2016 commented Jun 1, 2020

@wjhuang2016 Is master the only version that supports invisible index?

Yeah.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 2, 2020

@wjhuang2016 What about 不支持 VISIBLE/INVISIBLE 的索引 as written in 3.1/3.0/2.1?
image

@wjhuang2016
Copy link
Copy Markdown
Member Author

wjhuang2016 commented Jun 2, 2020

@wjhuang2016 What about 不支持 VISIBLE/INVISIBLE 的索引 as written in 3.1/3.0/2.1?
image

Invisible index is not a common feature. I think I should mention it only if we support it.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 2, 2020

@wjhuang2016 Got it. What about removing this line in 3.1/3.0/2.1?

@wjhuang2016
Copy link
Copy Markdown
Member Author

wjhuang2016 commented Jun 2, 2020

@wjhuang2016 Got it. What about removing this line in 3.1/3.0/2.1?

Good idea.

TomShawn
TomShawn approved these changes Jun 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 2, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2020
@TomShawn TomShawn removed the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 2, 2020

/run-all-tests

@sre-bot sre-bot merged commit 21c7d0a into release-4.0 Jun 2, 2020
@yikeke yikeke deleted the wjhuang2016-patch-3 branch June 12, 2020 05:40
This was referenced Jun 12, 2020
Merged
Merged
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@TomShawn TomShawn mentioned this pull request Jul 3, 2020
Closed
5 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 3, 2020
@ti-srebot ti-srebot mentioned this pull request Jul 6, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 left review comments

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wjhuang2016 @TomShawn @sre-bot @bb7133 @yikeke