Skip to content

add descriptions about new params for plan cache#3448

Merged
sre-bot merged 5 commits into
masterfrom
lawyerphx-patch-1
Jun 2, 2020
Merged

add descriptions about new params for plan cache#3448
sre-bot merged 5 commits into
masterfrom
lawyerphx-patch-1

Conversation

@danmay319
Copy link
Copy Markdown
Contributor

@danmay319 danmay319 commented Jun 2, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@danmay319 danmay319 added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. labels Jun 2, 2020
@danmay319 danmay319 requested a review from djshow832 June 2, 2020 06:42
@danmay319 danmay319 requested a review from TomShawn June 2, 2020 06:50
TomShawn
TomShawn reviewed Jun 2, 2020
View reviewed changes
Comment thread statement-summary-tables.md Outdated
Comment thread statement-summary-tables.md Outdated
Comment thread statement-summary-tables.md Outdated
djshow832
djshow832 reviewed Jun 2, 2020
View reviewed changes
Comment thread statement-summary-tables.md Outdated
Comment thread statement-summary-tables.md Outdated
danmay319 and others added 4 commits June 2, 2020 15:06
@danmay319 @TomShawn
Update statement-summary-tables.md
3113de9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@danmay319 @TomShawn
Update statement-summary-tables.md
22c4138 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@danmay319
address comment
af78225
@danmay319
Update statement-summary-tables.md
af1992b
@danmay319 danmay319 requested review from TomShawn and djshow832 June 2, 2020 07:19
TomShawn
TomShawn approved these changes Jun 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Jun 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/PTAL This PR is ready for reviewing. labels Jun 2, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 2, 2020

/run-all-tests

@sre-bot sre-bot merged commit 715807b into master Jun 2, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 2, 2020
@danmay319 @sre-bot
cherry pick pingcap#3448 to release-4.0
35fa885 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 2, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 2, 2020

cherry pick to release-4.0 in PR #3451

sre-bot added a commit that referenced this pull request Jun 2, 2020
@sre-bot
add descriptions about new params for plan cache (#3448) (#3451)
1f780d1
@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Jun 10, 2020
@toutdesuite toutdesuite mentioned this pull request Jun 10, 2020
Merged
5 tasks
@overvenus overvenus deleted the lawyerphx-patch-1 branch June 16, 2020 05:41
@toutdesuite toutdesuite removed the translation/doing This PR’s assignee is translating this PR. label Jun 17, 2020
@toutdesuite toutdesuite added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jun 17, 2020
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2020
Merged
5 tasks
@jiaqizho jiaqizho mentioned this pull request Dec 22, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djshow832 djshow832 Awaiting requested review from djshow832

2 more reviewers

@zz-jason zz-jason zz-jason approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@toutdesuite toutdesuite

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

record plan cache hit ratio or count in statement summary table

7 participants

@danmay319 @sre-bot @zz-jason @djshow832 @TomShawn @toutdesuite @yikeke