Skip to content

Remove output sample of TRACE because it's too long#3492

Merged
yikeke merged 1 commit into
pingcap:masterfrom
djshow832:fix_trace
Jun 4, 2020
Merged

Remove output sample of TRACE because it's too long#3492
yikeke merged 1 commit into
pingcap:masterfrom
djshow832:fix_trace

Conversation

@djshow832
Copy link
Copy Markdown
Contributor

@djshow832 djshow832 commented Jun 4, 2020

What is changed, added or deleted? (Required)

The output of TRACE is ALWAYS too long to produce PDF of this doc.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@djshow832 djshow832 requested review from yikeke and zimulala June 4, 2020 07:57
yikeke
yikeke approved these changes Jun 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 4, 2020
zimulala
zimulala reviewed Jun 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit ed97b3e into pingcap:master Jun 4, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 4, 2020
@djshow832 @sre-bot
cherry pick pingcap#3492 to release-4.0
61b1351 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 4, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 4, 2020

cherry pick to release-4.0 in PR #3493

yikeke pushed a commit that referenced this pull request Jun 4, 2020
@sre-bot @djshow832
cherry pick #3492 to release-4.0 (#3493)
09643bb 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: djshow832 <873581766@qq.com>
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 16, 2020
@tangenta tangenta mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
5 tasks
@djshow832 djshow832 deleted the fix_trace branch May 26, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala left review comments

+1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tangenta tangenta

Labels

translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@djshow832 @sre-bot @zimulala @yikeke @tangenta