tiup: add offline update tiup#3540
Merged
Merged
Conversation
lonng
approved these changes
Jun 6, 2020
yikeke
suggested changes
Jun 7, 2020
Contributor
There was a problem hiding this comment.
不过感觉这个第 6 步不应该是离线部署 TiDB 集群的步骤？（在第 5 步已经部署结束了）而是维护/升级本地集群的方式？放这是不是有点 off topic 呢 @lonng @lichunzhu
yikeke
added
needs-cherry-pick-4.0
translation/doing
Contributor
Author
是有点 off topic，是怎么行文比较好呢？ |
Contributor
这段的意思是，在使用 tiup 离线部署 tidb 的情况下，如果要升级本地集群，必须要先更新本地 tiup 镜像对吗？如果是这样的话，这一段放到升级文档里怎么样？ 我觉得可以在升级文档的「升级兼容性说明」后面加上一段，让用户先判断自己的集群是离线部署还是在线部署的。如果是离线部署，就先阅读这个 PR 里的这段内容；如果是在线部署，就直接跳过这段内容往下读。 这样可以不？ @lichunzhu |
kissmydb
suggested changes
Jun 8, 2020
Contributor
kissmydb
left a comment
kissmydb
left a comment
There was a problem hiding this comment.
内容本身没有问题，但位置需要调整一下。这篇文档是离线部署，而内容是升级相关。建议新建一个和【upgrade-tidb-using-tiup】并列的离线升级的文档，把新增的内容挪过去。
yikeke
reviewed
Jun 8, 2020
yikeke
reviewed
Jun 8, 2020
…iUPOfflineUpdate
yikeke
approved these changes
Jun 8, 2020
Contributor
Author
|
我再加个刚刚看到的小bug |
yikeke
reviewed
Jun 8, 2020
Contributor
Author
好了 |
kissmydb
reviewed
Jun 8, 2020
kissmydb
reviewed
Jun 8, 2020
| + 运维操作 | ||
| + 升级 TiDB 版本 | ||
| + [使用 TiUP（推荐）](/upgrade-tidb-using-tiup.md) | ||
| + [使用 TiUP 离线镜像（推荐）](/upgrade-tidb-using-tiup-offline.md) |
Contributor
There was a problem hiding this comment.
Suggested change
| + [使用 TiUP 离线镜像（推荐）](/upgrade-tidb-using-tiup-offline.md) | |
| + [使用 TiUP 离线升级（推荐）](/upgrade-tidb-using-tiup-offline.md) |
Co-authored-by: kissmydb <likun@pingcap.com>
Contributor
|
/merge |
sre-bot
added
the
status/can-merge
Contributor
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #3557 |
yikeke
pushed a commit
that referenced
this pull request
Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com> Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
5 tasks
5 tasks
ran-huang
changed the title
5 tasks
5 tasks
ran-huang
added
translation/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update how to update offline tiup mirror.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?