Skip to content

Add tispark into TOC#3575

Merged
sre-bot merged 3 commits into
masterfrom
tispark-in-toc
Jun 10, 2020
Merged

Add tispark into TOC#3575
sre-bot merged 3 commits into
masterfrom
tispark-in-toc

Conversation

@zanmato1984
Copy link
Copy Markdown
Contributor

@zanmato1984 zanmato1984 commented Jun 9, 2020 •
edited by yikeke
Loading

What is changed, added or deleted? (Required)

Add two dangling tispark docs into TOC.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@zanmato1984 zanmato1984 requested review from kissmydb and yikeke June 9, 2020 07:20
@yikeke yikeke requested a review from lilin90 June 9, 2020 07:21
yikeke
yikeke reviewed Jun 9, 2020
View reviewed changes
Comment thread TOC.md
+ [Loader](/loader-overview.md)
+ [Mydumper](/mydumper-overview.md)
+ [Syncer](/syncer-overview.md)
+ TiSpark
Copy link
Copy Markdown
Contributor

@yikeke yikeke Jun 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tispark 文档到时候还会单开一个 repo 放置对吧？ @lilin90 那是不是这一块应该放到「参考指南」下？

Copy link
Copy Markdown
Member

@lilin90 lilin90 Jun 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yikeke 之前目录调整归到了 Tools 大类下，目前先这样放着也可以。

Copy link
Copy Markdown
Contributor

@yikeke yikeke Jun 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果暂时 tispark 文档比较少，不考虑单独开 repo 维护，可以暂时先放在「生态工具」下。 @kissmydb @zanmato1984

@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 9, 2020
@yikeke yikeke self-assigned this Jun 9, 2020
kissmydb
kissmydb reviewed Jun 9, 2020
View reviewed changes
Comment thread TOC.md Outdated
+ [Syncer](/syncer-overview.md)
+ TiSpark
+ [TiSpark 用户指南](/tispark-overview.md)
+ [TiSpark 快速入门指南](/get-started-with-tispark.md)
Copy link
Copy Markdown
Contributor

@kissmydb kissmydb Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个放在前面吧，并改为「TiSpark 快速上手」

Copy link
Copy Markdown
Contributor Author

@zanmato1984 zanmato1984 Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed, PTAL.

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 9, 2020
yikeke
yikeke approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 10, 2020

PTAL again @kissmydb

kissmydb
kissmydb approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 10, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2020
@yikeke yikeke removed the status/require-change Needs the author to address comments. label Jun 10, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 10, 2020

/run-all-tests

@sre-bot sre-bot merged commit dcf758d into master Jun 10, 2020
@yikeke yikeke deleted the tispark-in-toc branch June 10, 2020 07:13
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 10, 2020
@zanmato1984 @sre-bot
cherry pick pingcap#3575 to release-4.0
f551d2b 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 10, 2020
Merged
5 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 10, 2020

cherry pick to release-4.0 in PR #3586

@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 10, 2020
sre-bot added a commit that referenced this pull request Jun 10, 2020
@sre-bot @zanmato1984
Add tispark into TOC (#3575) (#3586)
9a4bf64 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: ruoxi <zanmato1984@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 Awaiting requested review from lilin90

2 more reviewers

@kissmydb kissmydb kissmydb approved these changes

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yikeke yikeke

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zanmato1984 @yikeke @sre-bot @kissmydb @lilin90