Skip to content

update warning for placement rules#3664

Merged
yikeke merged 1 commit into
pingcap:masterfrom
jackysp:update_warning
Jun 15, 2020
Merged

update warning for placement rules#3664
yikeke merged 1 commit into
pingcap:masterfrom
jackysp:update_warning

Conversation

@jackysp
Copy link
Copy Markdown
Contributor

@jackysp jackysp commented Jun 15, 2020 •
edited
Loading

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@jackysp
update warning of placement rules
5d87e26 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp changed the title update warning of placement rules update warning for placement rules Jun 15, 2020
yikeke
yikeke approved these changes Jun 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jun 15, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jun 15, 2020

Please update pingcap/docs#2832 according to this PR. @jackysp

@yikeke yikeke merged commit a5163f4 into pingcap:master Jun 15, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 15, 2020
@jackysp @ti-srebot
cherry pick pingcap#3664 to release-4.0
165f368 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 15, 2020

cherry pick to release-4.0 in PR #3665

ti-srebot added a commit that referenced this pull request Jun 15, 2020
@ti-srebot @jackysp
update warning for placement rules (#3664) (#3665)
c42d33c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Jack Yu <yusp@pingcap.com>
@jackysp jackysp mentioned this pull request Jun 16, 2020
Merged
5 tasks
@yikeke yikeke mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jackysp jackysp

Labels

translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackysp @yikeke @ti-srebot