Skip to content

Update playground docs#3747

Merged
ti-srebot merged 4 commits into
pingcap:masterfrom
july2993:up_play
Jun 19, 2020
Merged

Update playground docs#3747
ti-srebot merged 4 commits into
pingcap:masterfrom
july2993:up_play

Conversation

@july2993
Copy link
Copy Markdown
Contributor

@july2993 july2993 commented Jun 19, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

update playground docs.
add about pump&drainer and more command

Which TiDB version(s) do your changes apply to? (Required)

not relate to tidb version

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@july2993 july2993 requested review from lonng and lucklove June 19, 2020 09:20
@TomShawn TomShawn self-requested a review June 19, 2020 10:03
@TomShawn TomShawn self-assigned this Jun 19, 2020
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 19, 2020
lonng
lonng approved these changes Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn reviewed Jun 19, 2020
View reviewed changes
Comment thread tiup/tiup-playground.md Outdated
TomShawn
TomShawn reviewed Jun 19, 2020
View reviewed changes
Comment thread tiup/tiup-playground.md Outdated
Comment thread tiup/tiup-playground.md Outdated
july2993 and others added 2 commits June 19, 2020 19:20
@july2993 @TomShawn
Apply suggestions from code review
78fee33 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@july2993
Merge branch 'master' into up_play
5ae8fdd
TomShawn
TomShawn reviewed Jun 19, 2020
View reviewed changes
Comment thread tiup/tiup-playground.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 19, 2020

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 19, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 1d49a70 into pingcap:master Jun 19, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 19, 2020
@july2993 @ti-srebot
cherry pick pingcap#3747 to release-4.0
2f0820d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 19, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 19, 2020

cherry pick to release-4.0 in PR #3748

ti-srebot added a commit that referenced this pull request Jun 19, 2020
@ti-srebot @july2993
Update playground docs (#3747) (#3748)
097f19c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: july2993 <july2993@gmail.com>
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@july2993 july2993 deleted the up_play branch June 29, 2020 03:11
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 14, 2020
@TomShawn TomShawn mentioned this pull request Jul 14, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucklove lucklove Awaiting requested review from lucklove

2 more reviewers

@TomShawn TomShawn TomShawn left review comments

@lonng lonng lonng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@july2993 @TomShawn @ti-srebot @lonng @yikeke