Skip to content

Fix auto assign config#3778

Merged
ti-srebot merged 8 commits into
masterfrom
fix-auto-assign-config
Jun 23, 2020
Merged

Fix auto assign config#3778
ti-srebot merged 8 commits into
masterfrom
fix-auto-assign-config

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Jun 23, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@github-actions github-actions Bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 23, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 23, 2020
@github-actions github-actions Bot requested a review from ran-huang June 23, 2020 05:01
@yikeke yikeke requested a review from lilin90 June 23, 2020 05:16
lilin90
lilin90 reviewed Jun 23, 2020
View reviewed changes
Comment thread .github/assign-by-files.yml Outdated
yikeke and others added 2 commits June 23, 2020 13:46
comment out benchmark folder
f03529e
@yikeke @lilin90
Update .github/assign-by-files.yml
6c575ab 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90
lilin90 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Jun 23, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 23, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 9fd8a5f into master Jun 23, 2020
@yikeke yikeke deleted the fix-auto-assign-config branch June 23, 2020 06:01
@yikeke yikeke mentioned this pull request Jun 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ran-huang ran-huang Awaiting requested review from ran-huang

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yikeke @ti-srebot @lilin90