add dumpling into tidb tools by lichunzhu · Pull Request #3800 · pingcap/docs-cn

lichunzhu · 2020-06-28T06:31:30Z

What is changed, added or deleted? (Required)

add dumpling into tidb toolset.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

ti-srebot · 2020-06-30T08:46:08Z

@kennytm, @3pointer, @yikeke, PTAL.

kennytm · 2020-07-02T06:53:53Z

LGTM

yikeke · 2020-07-02T07:06:47Z

+# Dumpling 使用文档

-本文档介绍如何使用数据导出工具 [Dumpling](https://github.com/pingcap/dumpling)。该工具可以把存储在 TiDB 中的数据导出为 SQL 或者 CSV 格式，可以用于完成逻辑上的全量备份或者导出。
+本文档将详细介绍如何使用 Mydumper/TiDB Lightning 对 TiDB 进行全量备份与恢复。


这篇文档和 backup-and-restore-using-dumpling-lightning.md 都是讲「如何使用 Mydumper/TiDB Lightning 对 TiDB 进行全量备份与恢复」？两篇文档的区别或者侧重点是啥？

有笔误，我改下

kissmydb · 2020-07-02T07:21:15Z

+# Dumpling 使用文档

-本文档介绍如何使用数据导出工具 [Dumpling](https://github.com/pingcap/dumpling)。该工具可以把存储在 TiDB 中的数据导出为 SQL 或者 CSV 格式，可以用于完成逻辑上的全量备份或者导出。
+本文档将详细介绍如何使用 Mydumper/TiDB Lightning 对 TiDB 进行全量备份与恢复。


这句话不对吧，不是 mydumper 和 lightning 了

into refineDumplingDoc

kissmydb · 2020-07-02T07:29:31Z

+
+`dumpling` 是使用 go 开发的数据备份工具，项目地址可以参考 [`dumpling`](https://github.com/pingcap/dumpling)。

 Dumpling 的更多具体用法可以使用 --help 指令查看，或者查看[中文使用手册](https://github.com/pingcap/dumpling/blob/master/docs/cn/user-guide.md)。


建议把 git 中手册内容，整合到官网这篇中，其实也就是参数介绍，不要分散在 2 处了。

另外所有参数没有写默认值，比较重要的如：consistency

yikeke

LGTM. PTAL again @3pointer

ti-srebot · 2020-07-06T04:18:48Z

@yikeke,Thanks for your review.

ti-srebot

LGTM

3pointer

LGTM

ti-srebot · 2020-07-06T05:36:46Z

@3pointer, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

lichunzhu · 2020-07-06T05:54:42Z

@yikeke It sames that this PR can't pass CI check because of the dashboard document. But it looks fine to me when I check that anchor.

yikeke · 2020-07-06T07:04:06Z

@yikeke It sames that this PR can't pass CI check because of the dashboard document. But it looks fine to me when I check that anchor.

I fixed them in 71460e5.

yikeke · 2020-07-06T07:04:20Z

/merge

ti-srebot · 2020-07-06T07:04:36Z

/run-all-tests

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-06T07:24:54Z

cherry pick to release-4.0 in PR #3892

* cherry pick #3800 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Update backup-and-restore-using-dumpling-lightning.md Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

* align the structure of pingcap/docs-cn#3800 * revert * Update dumpling-overview.md * Update dumpling-overview.md * update backup-and-restore-using-dumpling-lightning.md * ADD summary * fix an anchor * Update dumpling-overview.md Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com> * Update dumpling-overview.md Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com> * Apply suggestions from code review Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com> * Apply suggestions from code review * Update dumpling-overview.md * parameter -> option * Update note format and add inline code format * fix 2 dead links from upstream Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>

add dumpling into tidb-tools

5cc5361

lichunzhu added status/DNM status/PTAL This PR is ready for reviewing. labels Jun 28, 2020

lichunzhu requested review from 3pointer, kennytm and yikeke June 28, 2020 06:31

lichunzhu commented Jun 28, 2020

View reviewed changes

Comment thread download-ecosystem-tools.md Outdated

lichunzhu added 2 commits June 28, 2020 14:36

fix lint

5748499

fix dead links

ba09197

TomShawn added size/large Changes of a large size. needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 28, 2020

update download link

9db2834

lichunzhu removed the status/DNM label Jul 2, 2020

merge master

9dd1f3c

kennytm reviewed Jul 2, 2020

View reviewed changes

Comment thread backup-and-restore-using-dumpling-lightning.md Outdated

Comment thread backup-and-restore-using-dumpling-lightning.md Outdated

Comment thread backup-and-restore-using-dumpling-lightning.md Outdated

Comment thread backup-and-restore-using-dumpling-lightning.md Outdated

address comment

84a1ba4

yikeke requested a review from kissmydb July 2, 2020 06:59

address comment

ffed12c

yikeke reviewed Jul 2, 2020

View reviewed changes

kissmydb reviewed Jul 2, 2020

View reviewed changes

lichunzhu added 4 commits July 2, 2020 15:22

refine docs

abde418

Merge branch 'master' into refineDumplingDoc

79e1d0b

fix

8818fc9

Merge branch 'refineDumplingDoc' of https://github.com/lichunzhu/docs-cn

73f56ad

into refineDumplingDoc

kissmydb reviewed Jul 2, 2020

View reviewed changes

yikeke reviewed Jul 2, 2020

View reviewed changes

Comment thread backup-and-restore-using-dumpling-lightning.md

yikeke reviewed Jul 2, 2020

View reviewed changes

Comment thread dumpling-overview.md Outdated

yikeke approved these changes Jul 6, 2020

View reviewed changes

ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2020

ti-srebot approved these changes Jul 6, 2020

View reviewed changes

yikeke added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2020

3pointer approved these changes Jul 6, 2020

View reviewed changes

Merge branch 'master' into refineDumplingDoc

c9e4e00

fix 2 anchors

71460e5

ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2020

ti-srebot merged commit 6a61173 into pingcap:master Jul 6, 2020

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 6, 2020

cherry pick pingcap#3800 to release-4.0

0700348

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 6, 2020

add dumpling into tidb tools (#3800) #3892

Merged

5 tasks

lichunzhu deleted the refineDumplingDoc branch July 6, 2020 07:25

YiniXu9506 mentioned this pull request Jul 7, 2020

chore: fix unclosed tag #3914

Merged

5 tasks

ti-srebot mentioned this pull request Jul 7, 2020

chore: fix unclosed tag (#3914) #3915

Merged

5 tasks

ran-huang mentioned this pull request Jul 28, 2020

en: add backup&restore to gcs using br pingcap/docs-tidb-operator#582

Merged

3 tasks

yikeke pushed a commit to yikeke/docs that referenced this pull request Jul 28, 2020

align the structure of pingcap/docs-cn#3800

e46b07f

yikeke mentioned this pull request Jul 28, 2020

add dumpling into tidb tools pingcap/docs#3453

Merged

9 tasks

yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 29, 2020

ti-srebot mentioned this pull request Jul 31, 2020

add dumpling into tidb tools (#3453) pingcap/docs#3498

Merged

9 tasks


		`dumpling` 是使用 go 开发的数据备份工具，项目地址可以参考 [`dumpling`](https://github.com/pingcap/dumpling)。

		Dumpling 的更多具体用法可以使用 --help 指令查看，或者查看[中文使用手册](https://github.com/pingcap/dumpling/blob/master/docs/cn/user-guide.md)。

Conversation

lichunzhu commented Jun 28, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

Uh oh!

ti-srebot commented Jun 30, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kennytm commented Jul 2, 2020

Uh oh!

yikeke Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

lichunzhu Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

lichunzhu Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

kissmydb Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

lichunzhu Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

kissmydb Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

kissmydb Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yikeke left a comment

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Jul 6, 2020

Uh oh!

ti-srebot left a comment

Choose a reason for hiding this comment

Uh oh!

3pointer left a comment

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Jul 6, 2020

Uh oh!

lichunzhu commented Jul 6, 2020

Uh oh!

yikeke commented Jul 6, 2020

Uh oh!

yikeke commented Jul 6, 2020

Uh oh!

ti-srebot commented Jul 6, 2020

Uh oh!

ti-srebot commented Jul 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants