Skip to content

Fix typos in 3 DC in 2 cities deployment doc#3829

Merged
ti-srebot merged 5 commits into
masterfrom
TomShawn-patch-1
Jul 7, 2020
Merged

Fix typos in 3 DC in 2 cities deployment doc#3829
ti-srebot merged 5 commits into
masterfrom
TomShawn-patch-1

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Jun 30, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Fix typos in 3 DC in 2 cities deployment doc.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. size/small Changes of a small size. type/bugfix This PR fixes a bug. needs-cherry-pick-4.0 labels Jun 30, 2020
@TomShawn TomShawn requested a review from lilin90 June 30, 2020 07:19
@github-actions github-actions Bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 30, 2020
@TomShawn TomShawn mentioned this pull request Jun 30, 2020
Merged
5 tasks
lilin90
lilin90 reviewed Jun 30, 2020
View reviewed changes
Comment thread three-data-centers-in-two-cities-deployment.md Outdated
lilin90
lilin90 reviewed Jun 30, 2020
View reviewed changes
Comment thread three-data-centers-in-two-cities-deployment.md Outdated
lilin90
lilin90 reviewed Jun 30, 2020
View reviewed changes
Comment thread three-data-centers-in-two-cities-deployment.md Outdated
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jun 30, 2020
@TomShawn @lilin90
Apply suggestions from code review
e0376d5 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn TomShawn removed status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 30, 2020
@TomShawn TomShawn self-assigned this Jun 30, 2020
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jun 30, 2020

Would you please also fix descriptions in 操作系统性能参数调优?

@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Jun 30, 2020

Would you please also fix descriptions in 操作系统性能参数调优?

Done in 1e36b7f.

@ti-srebot ti-srebot mentioned this pull request Jul 2, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 2, 2020

@lilin90, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 2, 2020

@TomShawn, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 4, 2020

@lilin90, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 4, 2020

@TomShawn, please update your pull request.

@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Jul 6, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 7, 2020

@lilin90, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 7, 2020

@TomShawn, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 7, 2020

No updates for a long time, close PR.

lilin90
lilin90 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 7, 2020

@lilin90,Thanks for your review.

@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 7, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 8e2c91a into master Jul 7, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 7, 2020
@TomShawn @ti-srebot
cherry pick pingcap#3829 to release-4.0
f145a37 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 7, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 7, 2020

cherry pick to release-4.0 in PR #3917

@TomShawn TomShawn deleted the TomShawn-patch-1 branch July 7, 2020 12:49
ti-srebot added a commit that referenced this pull request Jul 7, 2020
@ti-srebot @TomShawn
Fix typos in 3 DC in 2 cities deployment doc (#3829) (#3917)
e24a77f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

@TomShawn TomShawn

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomShawn @lilin90 @ti-srebot