Skip to content

Add scripts to verify anchors (#3835)#3855

Merged
yikeke merged 4 commits into
release-3.1from
add-anchor-check
Jul 3, 2020
Merged

Add scripts to verify anchors (#3835)#3855
yikeke merged 4 commits into
release-3.1from
add-anchor-check

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Jul 2, 2020

What is changed, added or deleted? (Required)

add anchor check from #3835

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@yikeke yikeke added the type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. label Jul 2, 2020
@yikeke yikeke requested a review from breezewish July 2, 2020 07:29
@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Jul 2, 2020

Error: /bin/bash: scripts/verify-link-anchors.sh: Permission denied. Do we need to change the script in this branch? @breeswish

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2020
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@TomShawn,Thanks for your review.

@yikeke yikeke merged commit d8e3f97 into release-3.1 Jul 3, 2020
@yikeke yikeke deleted the add-anchor-check branch July 3, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants