Skip to content

Add missing aliases for binlog docs#3918

Merged
TomShawn merged 1 commit into
pingcap:masterfrom
TomShawn:loader-aliasess
Jul 7, 2020
Merged

Add missing aliases for binlog docs#3918
TomShawn merged 1 commit into
pingcap:masterfrom
TomShawn:loader-aliasess

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Jul 7, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug. needs-cherry-pick-4.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Jul 7, 2020
@TomShawn TomShawn requested a review from ran-huang July 7, 2020 13:46
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

@ran-huang,Thanks for your review.

@TomShawn TomShawn merged commit b1f401f into pingcap:master Jul 7, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3919

TomShawn added a commit that referenced this pull request Jul 7, 2020
ti-srebot added a commit that referenced this pull request Jul 7, 2020
* cherry pick #3918 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update loader-overview.md

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the loader-aliasess branch July 7, 2020 14:07
@TomShawn TomShawn mentioned this pull request Jul 7, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants