Skip to content

perf-tuning: update anchors in wrong-index-solution#3934

Merged
TomShawn merged 2 commits into
pingcap:masterfrom
ran-huang:wrong-index-solution
Jul 9, 2020
Merged

perf-tuning: update anchors in wrong-index-solution#3934
TomShawn merged 2 commits into
pingcap:masterfrom
ran-huang:wrong-index-solution

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

@ran-huang ran-huang commented Jul 9, 2020

What is changed, added or deleted? (Required)

Refine some anchors to make the content more readable.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-4.0 labels Jul 9, 2020
@ran-huang ran-huang requested review from TomShawn and winoros July 9, 2020 11:18
winoros
winoros reviewed Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 9, 2020

@winoros, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@ran-huang ran-huang mentioned this pull request Jul 9, 2020
Merged
5 tasks
TomShawn
TomShawn approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 9, 2020

@TomShawn,Thanks for your review.

@TomShawn TomShawn merged commit 22fa5b0 into pingcap:master Jul 9, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 9, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3934 to release-4.0
c3a72fa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 9, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 9, 2020

cherry pick to release-4.0 in PR #3935

ran-huang added a commit that referenced this pull request Jul 9, 2020
@ti-srebot @ran-huang
cherry pick #3934 to release-4.0 (#3935)
17d150f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the wrong-index-solution branch July 9, 2020 12:42
@ti-srebot ti-srebot mentioned this pull request Jul 22, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros winoros left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ran-huang @ti-srebot @winoros @TomShawn