Skip to content

add tiflash store limit config version change warning#3941

Merged
ti-srebot merged 4 commits into
pingcap:masterfrom
birdstorm:add-tiflash-store-limit-change-warning
Jul 13, 2020
Merged

add tiflash store limit config version change warning#3941
ti-srebot merged 4 commits into
pingcap:masterfrom
birdstorm:add-tiflash-store-limit-change-warning

Conversation

@birdstorm
Copy link
Copy Markdown
Contributor

@birdstorm birdstorm commented Jul 10, 2020

What is changed, added or deleted? (Required)

adds warning for store-limit config change in tiflash document

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

ref #3831

@birdstorm birdstorm added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jul 10, 2020
@birdstorm birdstorm requested a review from flowbehappy July 10, 2020 04:14
@ti-srebot
Copy link
Copy Markdown
Contributor

@flowbehappy, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

Copy link
Copy Markdown
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@zanmato1984, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 13, 2020
@TomShawn TomShawn self-requested a review July 13, 2020 08:15
@TomShawn TomShawn self-assigned this Jul 13, 2020
Comment thread tiflash/tiflash-configuration.md Outdated
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jul 13, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 982bf85 into pingcap:master Jul 13, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.0 in PR #3957

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.1 in PR #3958

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3959

@birdstorm birdstorm deleted the add-tiflash-store-limit-change-warning branch July 13, 2020 09:08
ti-srebot added a commit that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: birdstorm <samuelwyf@hotmail.com>
TomShawn pushed a commit that referenced this pull request Jul 13, 2020
* cherry pick #3941 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update tiflash-configuration.md

Co-authored-by: birdstorm <samuelwyf@hotmail.com>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants