Skip to content

*: replace black-white-list by table filter (#3916)#3950

Merged
ran-huang merged 5 commits into
pingcap:release-3.1from
ti-srebot:release-3.1-a4c03158b30b
Jul 13, 2020
Merged

*: replace black-white-list by table filter (#3916)#3950
ran-huang merged 5 commits into
pingcap:release-3.1from
ti-srebot:release-3.1-a4c03158b30b

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Jul 13, 2020

cherry-pick #3916 to release-3.1

What is changed, added or deleted? (Required)

  • Add a doc for the "table filter" feature shared by all new TiDB ecosystem tools
  • Update related contents for BR and TiDB Lightning

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang @ti-srebot
cherry pick pingcap#3916 to release-3.1
708e759 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot ti-srebot added size/large Changes of a large size. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Jul 13, 2020
@ran-huang
Copy link
Copy Markdown
Contributor

ran-huang commented Jul 13, 2020

@TomShawn @kennytm
PTAL if the changes are aligned with pingcap/docs#3139. Thanks~

@ran-huang ran-huang requested review from TomShawn and kennytm July 13, 2020 03:50
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 13, 2020 •
edited
Loading

@ran-huang TiCDC-related documents are not applicable to v3.1. Please remove manage-ticdc.md. Also please fix dead links shown in the image. Links related to TiUP and TiCDC are also not applicable.
image

@ran-huang
Copy link
Copy Markdown
Contributor

ran-huang commented Jul 13, 2020

@TomShawn Comments addressed. PTAL~

TomShawn
TomShawn approved these changes Jul 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor Author

ti-srebot commented Jul 13, 2020

@TomShawn,Thanks for your review.

kennytm
kennytm reviewed Jul 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Copy Markdown
Contributor Author

ti-srebot commented Jul 13, 2020

@kennytm, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@ran-huang ran-huang merged commit 5d25a51 into pingcap:release-3.1 Jul 13, 2020
@ran-huang ran-huang mentioned this pull request Jul 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-huang ran-huang

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ran-huang @TomShawn @kennytm