update dumpling argument list#3974
Merged
Merged
Conversation
Contributor
|
@lichunzhu Please involve a technical review. |
Contributor
Author
|
@kennytm @WangXiangUSTC PTAL |
Contributor
Author
It sames that I don't have the right to request review from some one. |
kennytm
reviewed
Jul 16, 2020
| | -B 或 --database | 导出指定数据库 | | ||
| | -T 或 --tables-list | 导出指定数据表 | | ||
| | -f 或 --filter | 导出能匹配模式的表,语法可参考 [table-filter](https://github.com/pingcap/tidb-tools/blob/master/pkg/table-filter/README.md)(只有英文版) | "\*.\*" 不过滤任何库表 | | ||
| | -f 或 --filter | 导出能匹配模式的表,语法可参考 [table-filter](https://docs.pingcap.com/zh/tidb/stable/table-filter) | "\*.\*" 导出所有库表 | |
Contributor
There was a problem hiding this comment.
Suggested change
| | -f 或 --filter | 导出能匹配模式的表,语法可参考 [table-filter](https://docs.pingcap.com/zh/tidb/stable/table-filter) | "\*.\*" 导出所有库表 | | |
| | -f 或 --filter | 导出能匹配模式的表,语法可参考 [table-filter](/table-filter.md) | `*.*` 导出所有库表 | |
| | --csv-delimiter | csv 文件中字符类型变量的定界符 | '"' | | ||
| | --csv-separator | csv 文件中各值的分隔符 | ',' | | ||
| | --csv-null-value | csv 文件空值的表示 | "\\N" | | ||
| | --escape-backslash | 使用反斜线 ("\") 来注释导出文件中的特殊字符,为 false 时使用单引号 ("'") 注释 | true | |
Contributor
There was a problem hiding this comment.
Suggested change
| | --escape-backslash | 使用反斜线 ("\") 来注释导出文件中的特殊字符,为 false 时使用单引号 ("'") 注释 | true | | |
| | --escape-backslash | 使用反斜杠 (`\`) 来转义导出文件中的特殊字符 | true | |
| | --csv-separator | csv 文件中各值的分隔符 | ',' | | ||
| | --csv-null-value | csv 文件空值的表示 | "\\N" | | ||
| | --escape-backslash | 使用反斜线 ("\") 来注释导出文件中的特殊字符,为 false 时使用单引号 ("'") 注释 | true | | ||
| | --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 '{{.DB}}','{{.Table}}','{{.Index}}' 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' | |
Contributor
There was a problem hiding this comment.
please use ` to escape the special syntax
| | --csv-null-value | csv 文件空值的表示 | "\\N" | | ||
| | --escape-backslash | 使用反斜线 ("\") 来注释导出文件中的特殊字符,为 false 时使用单引号 ("'") 注释 | true | | ||
| | --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 '{{.DB}}','{{.Table}}','{{.Index}}' 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' | | ||
| | --status-addr | dumpling 的服务地址,包含了运行时的 pprof 信息 | ":8281" | |
Contributor
There was a problem hiding this comment.
Suggested change
| | --status-addr | dumpling 的服务地址,包含了运行时的 pprof 信息 | ":8281" | | |
| | --status-addr | Dumpling 的服务地址,包含了 Prometheus 拉取 metrics 信息及 pprof 调试的地址 | ":8281" | |
TomShawn
reviewed
Jul 16, 2020
| | --escape-backslash | 使用反斜杠 (`\`) 来转义导出文件中的特殊字符 | true | | ||
| | --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 `{{.DB}}`,`{{.Table}}`,`{{.Index}}` 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' | | ||
| | --status-addr | Dumpling 的服务地址,包含了 Prometheus 拉取 metrics 信息及 pprof 调试的地址 | ":8281" | | ||
| | --tidb-mem-quota-query | 单条 dumpling 导出 sql 的内存限制,单位为 B,默认为 32GB | 34359738368 | |
Contributor
There was a problem hiding this comment.
Suggested change
| | --tidb-mem-quota-query | 单条 dumpling 导出 sql 的内存限制,单位为 B,默认为 32GB | 34359738368 | | |
| | --tidb-mem-quota-query | 单条 dumpling 命令导出 SQL 语句的内存限制,单位为 byte,默认为 32 GB | 34359738368 | |
TomShawn
reviewed
Jul 16, 2020
| | --csv-separator | csv 文件中各值的分隔符 | ',' | | ||
| | --csv-null-value | csv 文件空值的表示 | "\\N" | | ||
| | --escape-backslash | 使用反斜杠 (`\`) 来转义导出文件中的特殊字符 | true | | ||
| | --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 `{{.DB}}`,`{{.Table}}`,`{{.Index}}` 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' | |
Contributor
There was a problem hiding this comment.
Suggested change
| | --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 `{{.DB}}`,`{{.Table}}`,`{{.Index}}` 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' | | |
| | --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 `{{.DB}}`、`{{.Table}}`、`{{.Index}}` 三个参数 <br/> 分别表示数据文件的库名、表名、分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' | |
TomShawn
reviewed
Jul 16, 2020
|
|
||
| | 主要参数 | 用途 | 默认值 | | ||
| | --------| --- | --- | | ||
| | -V 或 --version | 输出 dumpling 版本并直接退出 | |
Contributor
There was a problem hiding this comment.
Suggested change
| | -V 或 --version | 输出 dumpling 版本并直接退出 | | |
| | -V 或 --version | 输出 Dumpling 版本并直接退出 | |
TomShawn
approved these changes
Jul 16, 2020
Contributor
TomShawn
left a comment
There was a problem hiding this comment.
LGTM
@kennytm @WangXiangUSTC PTAL again
Contributor
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #3997 |
TomShawn
pushed a commit
that referenced
this pull request
Jul 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update dumpling arguments list.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?