Skip to content

update dumpling argument list#3974

Merged
TomShawn merged 5 commits into
pingcap:masterfrom
lichunzhu:refineDumplingDoc
Jul 17, 2020
Merged

update dumpling argument list#3974
TomShawn merged 5 commits into
pingcap:masterfrom
lichunzhu:refineDumplingDoc

Conversation

@lichunzhu
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Update dumpling arguments list.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Jul 16, 2020
@TomShawn TomShawn self-requested a review July 16, 2020 02:25
@TomShawn TomShawn self-assigned this Jul 16, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

@lichunzhu Please involve a technical review.

@lichunzhu
Copy link
Copy Markdown
Contributor Author

@kennytm @WangXiangUSTC PTAL

@lichunzhu
Copy link
Copy Markdown
Contributor Author

@lichunzhu Please involve a technical review.

It sames that I don't have the right to request review from some one.

Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread dumpling-overview.md Outdated
| -B 或 --database | 导出指定数据库 |
| -T 或 --tables-list | 导出指定数据表 |
| -f 或 --filter | 导出能匹配模式的表,语法可参考 [table-filter](https://github.com/pingcap/tidb-tools/blob/master/pkg/table-filter/README.md)(只有英文版) | "\*.\*" 不过滤任何库表 |
| -f 或 --filter | 导出能匹配模式的表,语法可参考 [table-filter](https://docs.pingcap.com/zh/tidb/stable/table-filter) | "\*.\*" 导出所有库表 |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| -f 或 --filter | 导出能匹配模式的表,语法可参考 [table-filter](https://docs.pingcap.com/zh/tidb/stable/table-filter) | "\*.\*" 导出所有库表 |
| -f 或 --filter | 导出能匹配模式的表,语法可参考 [table-filter](/table-filter.md) | `*.*` 导出所有库表 |

Comment thread dumpling-overview.md Outdated
| --csv-delimiter | csv 文件中字符类型变量的定界符 | '"' |
| --csv-separator | csv 文件中各值的分隔符 | ',' |
| --csv-null-value | csv 文件空值的表示 | "\\N" |
| --escape-backslash | 使用反斜线 ("\") 来注释导出文件中的特殊字符,为 false 时使用单引号 ("'") 注释 | true |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| --escape-backslash | 使用反斜线 ("\") 来注释导出文件中的特殊字符,为 false 时使用单引号 ("'") 注释 | true |
| --escape-backslash | 使用反斜杠 (`\`) 来转义导出文件中的特殊字符 | true |

Comment thread dumpling-overview.md Outdated
| --csv-separator | csv 文件中各值的分隔符 | ',' |
| --csv-null-value | csv 文件空值的表示 | "\\N" |
| --escape-backslash | 使用反斜线 ("\") 来注释导出文件中的特殊字符,为 false 时使用单引号 ("'") 注释 | true |
| --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 '{{.DB}}','{{.Table}}','{{.Index}}' 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use ` to escape the special syntax

Comment thread dumpling-overview.md Outdated
| --csv-null-value | csv 文件空值的表示 | "\\N" |
| --escape-backslash | 使用反斜线 ("\") 来注释导出文件中的特殊字符,为 false 时使用单引号 ("'") 注释 | true |
| --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 '{{.DB}}','{{.Table}}','{{.Index}}' 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' |
| --status-addr | dumpling 的服务地址,包含了运行时的 pprof 信息 | ":8281" |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| --status-addr | dumpling 的服务地址,包含了运行时的 pprof 信息 | ":8281" |
| --status-addr | Dumpling 的服务地址,包含了 Prometheus 拉取 metrics 信息及 pprof 调试的地址 | ":8281" |

Comment thread dumpling-overview.md Outdated
| --escape-backslash | 使用反斜杠 (`\`) 来转义导出文件中的特殊字符 | true |
| --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 `{{.DB}}`,`{{.Table}}`,`{{.Index}}` 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' |
| --status-addr | Dumpling 的服务地址,包含了 Prometheus 拉取 metrics 信息及 pprof 调试的地址 | ":8281" |
| --tidb-mem-quota-query | 单条 dumpling 导出 sql 的内存限制,单位为 B,默认为 32GB | 34359738368 |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| --tidb-mem-quota-query | 单条 dumpling 导出 sql 的内存限制,单位为 B,默认为 32GB | 34359738368 |
| --tidb-mem-quota-query | 单条 dumpling 命令导出 SQL 语句的内存限制,单位为 byte,默认为 32 GB | 34359738368 |

Comment thread dumpling-overview.md Outdated
| --csv-separator | csv 文件中各值的分隔符 | ',' |
| --csv-null-value | csv 文件空值的表示 | "\\N" |
| --escape-backslash | 使用反斜杠 (`\`) 来转义导出文件中的特殊字符 | true |
| --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 `{{.DB}}`,`{{.Table}}`,`{{.Index}}` 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 `{{.DB}}`,`{{.Table}}`,`{{.Index}}` 三个参数 <br/> 分别表示数据文件的库名,表名,分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' |
| --output-filename-template | [golang template](https://golang.org/pkg/text/template/#hdr-Arguments) 格式表示的数据文件名格式 <br/> 支持 `{{.DB}}``{{.Table}}``{{.Index}}` 三个参数 <br/> 分别表示数据文件的库名、表名、分块 ID | '{{.DB}}.{{.Table}}.{{.Index}}' |

Comment thread dumpling-overview.md Outdated

| 主要参数 | 用途 | 默认值 |
| --------| --- | --- |
| -V 或 --version | 输出 dumpling 版本并直接退出 |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| -V 或 --version | 输出 dumpling 版本并直接退出 |
| -V 或 --version | 输出 Dumpling 版本并直接退出 |

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kennytm @WangXiangUSTC PTAL again

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@kennytm,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn merged commit eef4e7d into pingcap:master Jul 17, 2020
@lichunzhu lichunzhu deleted the refineDumplingDoc branch July 17, 2020 11:08
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3997

TomShawn pushed a commit that referenced this pull request Jul 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@yikeke yikeke assigned yikeke and unassigned TomShawn Jul 29, 2020
@yikeke yikeke removed the translation/doing This PR’s assignee is translating this PR. label Jul 29, 2020
@yikeke yikeke added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants